From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 99F977030F; Fri, 15 Jan 2021 16:03:11 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 99F977030F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1610715791; bh=7yyRLa9Ndfw0IWRukU3zJlXgDET0vlU1TdUjeO3E0IU=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=lyZo96Fex9F1SESQ/lYo+J+NLmOJSW5v1Gr2BeuucZIrRxvU8xsGZsJeLy2GWQNsP UVcZSgmnszLJjnVgXK+MWoj+hNibk/ju0GswfPQrzVu7os4Hp0AJ2ETTIrh4md3FPj ROs6SNpOl0UNkIMvMecaSEmLKnhcwiG1plvWuCXQ= Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C1B317030F for ; Fri, 15 Jan 2021 16:03:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C1B317030F Received: by smtp40.i.mail.ru with esmtpa (envelope-from ) id 1l0Okv-0001nw-Ve; Fri, 15 Jan 2021 16:03:10 +0300 To: Sergey Bronnikov , tarantool-patches@dev.tarantool.org Cc: v.shpilevoy@tarantool.org References: <5665f0ed-0b99-d974-044b-60865a856c6d@tarantool.org> Message-ID: Date: Fri, 15 Jan 2021 16:03:09 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <5665f0ed-0b99-d974-044b-60865a856c6d@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: ru X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9D0E79FBC973162CD9807AE62CAC2B33C765C844EAC374FFF00894C459B0CD1B94AC426342E847D68B769E3171AC82A7602587BF5ABB16BCD6B7995677FB1BAB6 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE731D82F3F177D3BCDEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637CF19945FAF91394A8638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC6FD3D10E84685BD8A59F9DE9689F5E7B5A7E5EF5B610E460389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C091DAD9F922AA71188941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B625DC386152A6764ACC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C22495FFE54222B9F336176E601842F6C81A12EF20D2F80756B5F7E9C4E3C761E06A776E601842F6C81A127C277FBC8AE2E8BD5D81A76D8941E4A3AA81AA40904B5D9DBF02ECDB25306B2B25CBF701D1BE8734AD6D5ED66289B5278DA827A17800CE7509F8262B3B2DD1667F23339F89546C5A8DF7F3B2552694A6FED454B719173D6725E5C173C3A84C31BC22E60DA9664CB089D37D7C0E48F6C5571747095F342E857739F23D657EF2B6825BDBE14D8E7024847893F9AA87235E5BFE6E7EFDEDCD789D4C264860C145E X-C1DE0DAB: 0D63561A33F958A529BA604CF8A386481B160BAB71D8EE94DC33B1453967EA0BD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D349BD6FB698A487E7E63FFD1EEF03F523DA62AE6818C9734055C5BD415A72D4A7A10F0328DEFFDC1181D7E09C32AA3244C7F7C91040808A9527492A918262429ADA995755A1445935EFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojT/h6YDL0UQ5BHI0R0N6Ehg== X-Mailru-Sender: 583F1D7ACE8F49BDF28A51E06CB90EC1CB28DB18F2C7403D9F7E72FA68768E6AC8B7CAE0D173BC8E823C4E0A9438D55D74690CA6451351EDEC462FDC9CAD1E11B969B486931C0B990F27244EEAA5B9A5AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 2/2] luacheck: fix warnings in test/box-tap X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 15.01.2021 15:56, Sergey Bronnikov пишет: > Thanks for review! > > On 15.01.2021 15:40, Serge Petrenko wrote: >> >> >> 15.01.2021 14:22, sergeyb@tarantool.org пишет: >>> From: Sergey Bronnikov >>> >>> Follows up #5457 >>> --- >>>   test/box-tap/feedback_daemon.test.lua | 6 +++--- >>>   1 file changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/test/box-tap/feedback_daemon.test.lua >>> b/test/box-tap/feedback_daemon.test.lua >>> index 123033cda..8cfbf31d7 100755 >>> --- a/test/box-tap/feedback_daemon.test.lua >>> +++ b/test/box-tap/feedback_daemon.test.lua >>> @@ -124,8 +124,8 @@ local fh = fio.open("feedback.json") >>>   test:ok(fh, "file is created") >>>   local file_data = fh:read() >>>   -- Ignore the report time. The data should be equal other than that. >>> -feedback_save = string.gsub(feedback_save, 'time:(%d+)', 'time:0') >>> -file_data = string.gsub(feedback_save, 'time:(%d+)', 'time:0') >>> +feedback_save = string.gsub(feedback_save, '"time":(%d+)', 'time:0') >>> +file_data = string.gsub(file_data, '"time":(%d+)', 'time:0') >> Thanks for finding this typo! >> Please also replace `time:0` with `"time":0` > > Sure. > > @@ -124,8 +124,8 @@ local fh = fio.open("feedback.json") >  test:ok(fh, "file is created") >  local file_data = fh:read() >  -- Ignore the report time. The data should be equal other than that. > -feedback_save = string.gsub(feedback_save, '"time":(%d+)', 'time:0') > -file_data = string.gsub(file_data, '"time":(%d+)', 'time:0') > +feedback_save = string.gsub(feedback_save, '"time":(%d+)', '"time":0') > +file_data = string.gsub(file_data, '"time":(%d+)', '"time":0') >  test:is(file_data, feedback_save, "data is equal") >  fh:close() >  fio.unlink("feedback.json") Thanks, LGTM. > >> >> Other than that LGTM. >> >>>   test:is(file_data, feedback_save, "data is equal") >>>   fh:close() >>>   fio.unlink("feedback.json") >>> @@ -247,7 +247,7 @@ box.space.features_memtx_empty:drop() >>>   box.space.features_memtx:drop() >>>   box.space.features_sync:drop() >>>   -function check_stats(stat) >>> +local function check_stats(stat) >>>       local sub = test:test('feedback operation stats') >>>       sub:plan(18) >>>       local box_stat = box.stat() >> -- Serge Petrenko