Tarantool development patches archive
 help / color / mirror / Atom feed
From: Imeev Mergen <imeevma@tarantool.org>
To: "n.pettik" <korablev@tarantool.org>, tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v4 5/6] sql: 'PRAGMA' result in YAML format
Date: Thu, 24 Jan 2019 17:53:22 +0300	[thread overview]
Message-ID: <d295691a-005e-3dd2-2f75-16143503b960@tarantool.org> (raw)
In-Reply-To: <4424957D-71D2-4C31-A288-42E22462055B@tarantool.org>

Hi! Thank you for review. Changed commit-message.

On 1/20/19 3:19 AM, n.pettik wrote:
>> New version:
>>
>> commit a3e6e457680e9aef5af78ca7a92f1572fcfbdef4
>> Author: Mergen Imeev <imeevma@gmail.com>
>> Date:   Thu Dec 13 21:07:31 2018 +0300
>>
>>     sql: 'PRAGMA' result in YAML format
> Commit's subject would look better with verb.
>
> For instance:
>
> sql: get results of PRAGMA statement in YAML format
>
> Or sort of.
>
> The rest is OK in this patch-set, so LGTM.
>
Fixed. New commit-message:

commit 1a7fd53719a4790845c68f815a4f1a9f4f84b97a
Author: Mergen Imeev <imeevma@gmail.com>
Date:   Thu Dec 13 21:07:31 2018 +0300

     sql: get results of PRAGMA statement in YAML format

     Currently box.sql.execute ('PRAGMA') returns nothing, but prints
     list of pragmas and their statuses to stdout. Such strategy is
     considered to be wrong since output of this command would be
     unavailable for users who redirect stdout, use net box connection
     etc. This patch makes the command to return result as the rest of
     SQL commands. The result contains only FLAG-type pragmas and their
     statuses in YAML format.

  reply	other threads:[~2019-01-24 14:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-19 12:37 [tarantool-patches] [PATCH v4 0/6] sql: set column types for EXPLAIN and PRAGMA imeevma
2019-01-19 12:37 ` [tarantool-patches] [PATCH v4 1/6] sql: remove unused macros from pragma.c and pragma.h imeevma
2019-01-20  0:16   ` [tarantool-patches] " n.pettik
2019-01-24 14:52     ` Imeev Mergen
2019-01-19 12:37 ` [tarantool-patches] [PATCH v4 2/6] sql: fix "PRAGMA parser_trace" result imeevma
2019-01-19 12:37 ` [tarantool-patches] [PATCH v4 3/6] sql: Show currently set sql_default_engine imeevma
2019-01-19 12:37 ` [tarantool-patches] [PATCH v4 4/6] sql: fix "PRAGMA case_sensitive_like" result imeevma
2019-01-19 12:37 ` [tarantool-patches] [PATCH v4 5/6] sql: 'PRAGMA' result in YAML format imeevma
2019-01-20  0:19   ` [tarantool-patches] " n.pettik
2019-01-24 14:53     ` Imeev Mergen [this message]
2019-01-19 12:37 ` [tarantool-patches] [PATCH v4 6/6] sql: set column types for EXPLAIN and PRAGMA imeevma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d295691a-005e-3dd2-2f75-16143503b960@tarantool.org \
    --to=imeevma@tarantool.org \
    --cc=korablev@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v4 5/6] sql: '\''PRAGMA'\'' result in YAML format' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox