From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH] sql: refactor SQL delete to allow Lua spaces
Date: Mon, 21 May 2018 12:47:56 +0300 [thread overview]
Message-ID: <d210a093-e869-dea8-307b-92090c5dd940@tarantool.org> (raw)
In-Reply-To: <20180521082048.2n5vzzsgxcb7fyss@tarantool.org>
Hello. Thanks for the fixes!
>
> diff --git a/src/box/sql/build.c b/src/box/sql/build.c
> index df75186..68f81e8 100644
> --- a/src/box/sql/build.c
> +++ b/src/box/sql/build.c
> @@ -2108,107 +2108,97 @@ sqlite3CreateView(Parse * pParse, /* The parsing context */
> }
> #endif /* SQLITE_OMIT_VIEW */
>
> -#if !defined(SQLITE_OMIT_VIEW)
> -/*
> - * The Table structure pTable is really a VIEW. Fill in the names of
> - * the columns of the view in the pTable structure. Return the number
> - * of errors. If an error is seen leave an error message in pParse->zErrMsg.
> - */
> -int
> -sqlite3ViewGetColumnNames(Parse * pParse, Table * pTable)
> +bool
In Tarantool code style we do not return boolean on non-check functions.
0 or -1, please.
The rest of patch is ok.
next prev parent reply other threads:[~2018-05-21 9:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 13:36 [tarantool-patches] " Kirill Yukhin
2018-05-18 21:07 ` [tarantool-patches] " Vladislav Shpilevoy
2018-05-21 8:20 ` Kirill Yukhin
2018-05-21 9:47 ` Vladislav Shpilevoy [this message]
2018-05-21 10:25 ` Kirill Yukhin
2018-05-21 10:49 ` Vladislav Shpilevoy
2018-05-21 11:24 ` Kirill Yukhin
2018-05-21 11:39 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d210a093-e869-dea8-307b-92090c5dd940@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] sql: refactor SQL delete to allow Lua spaces' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox