From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org, Kirill Yukhin <kyukhin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 2/3] sql: remove expressions from SQL indexes
Date: Fri, 1 Jun 2018 21:00:50 +0300 [thread overview]
Message-ID: <d1c0994c-0204-aa18-3253-f3d33c0bf0fe@tarantool.org> (raw)
In-Reply-To: <787e55ddaaeeec54e870d3f493fc235fe64ffd51.1527865931.git.kyukhin@tarantool.org>
Thanks for the patch! See 2 comments below.
On 01/06/2018 18:16, Kirill Yukhin wrote:
> Legacy SQL FE was able to create indexes w/ expressions.
> Tarantool will employ diofferenct scheme to implement
1. diofferenct?
> functional indexes, thus code handling it in SQL FE is
> dead and redundant. Remove it.
>
> Part of #3235
2. I pushed my review fixes. Please, consider them as squash if ok.
> ---
> src/box/sql/build.c | 22 ++++++---------
> src/box/sql/delete.c | 3 +--
> src/box/sql/expr.c | 12 ++-------
> src/box/sql/insert.c | 72 +++++++++++++++----------------------------------
> src/box/sql/sqliteInt.h | 6 -----
> src/box/sql/where.c | 27 ++-----------------
> src/box/sql/wherecode.c | 13 +++------
> src/box/sql/whereexpr.c | 36 +++----------------------
> 8 files changed, 42 insertions(+), 149 deletions(-)
>
next prev parent reply other threads:[~2018-06-01 18:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 15:16 [tarantool-patches] [PATCH 0/3] sql: implement point where for DELETE stmts Kirill Yukhin
2018-06-01 15:16 ` [tarantool-patches] [PATCH 1/3] sql: fetch primary index for affinity only Kirill Yukhin
2018-06-01 18:00 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-07 12:03 ` Kirill Yukhin
2018-06-07 15:01 ` Vladislav Shpilevoy
2018-06-08 8:25 ` Kirill Yukhin
2018-06-01 15:16 ` [tarantool-patches] [PATCH 2/3] sql: remove expressions from SQL indexes Kirill Yukhin
2018-06-01 18:00 ` Vladislav Shpilevoy [this message]
2018-06-01 15:16 ` [tarantool-patches] [PATCH 3/3] sql: implement point where for DELETE stmts Kirill Yukhin
2018-06-01 18:00 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-18 2:11 ` n.pettik
2018-06-18 10:44 ` Vladislav Shpilevoy
2018-06-18 10:51 ` Vladislav Shpilevoy
2018-06-18 12:29 ` n.pettik
2018-06-18 12:40 ` Vladislav Shpilevoy
2018-06-18 14:00 ` n.pettik
2018-06-18 14:17 ` Vladislav Shpilevoy
2018-06-19 8:03 ` Kirill Yukhin
2018-06-14 12:41 ` [tarantool-patches] Re: [PATCH 0/3] " Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1c0994c-0204-aa18-3253-f3d33c0bf0fe@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 2/3] sql: remove expressions from SQL indexes' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox