From: Serge Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Konstantin Osipov <kostja.osipov@gmail.com>, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, gorcunov@gmail.com, tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH v3] wal: introduce limits on simultaneous writes Date: Fri, 12 Mar 2021 20:10:04 +0300 [thread overview] Message-ID: <d1179904-55ae-57ac-9454-554589d9c26d@tarantool.org> (raw) In-Reply-To: <20210310081804.GA87351@starling> 10.03.2021 11:18, Konstantin Osipov пишет: > * Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org> [21/03/09 23:44]: >> Hi! Thanks for the patch! >> >> LGTM. >> >>> https://github.com/tarantool/tarantool/issues/5536 >>> https://github.com/tarantool/tarantool/tree/sp/gh-5536-replica-oom > I don't understand why you need two parameters, size and len. What > difference does it make how many requests are in the queue? The > queue is IO and memory bound, not CPU bound, at least not more cpu > bound than any other subsystem. > > Pushing the problem to the user by forcing them to choose not one, > but two configuration values is poor design. How am I supposed to > know what is the right value for the option? After some consideration, let's only leave size. I've force pushed the changes on the branch. I've also implemented some kind of a fiber semaphore in a separate commit on top. I'm not sure I like how it turned out, so feel free to throw it away. Or keep it. > > I guess don't know it either - the patch was not followed by > a benchmark which would prove the selected defaults are optimal. > > Tarantool has an incoming throttling limit which makes the whole > system work like a clock: it's the fiber pool size and net msg > size. They were carefully selected after days and weeks of > testing. > -- Serge Petrenko
next prev parent reply other threads:[~2021-03-12 17:10 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-24 19:35 Serge Petrenko via Tarantool-patches 2021-02-24 19:40 ` Serge Petrenko via Tarantool-patches 2021-02-25 13:05 ` Konstantin Osipov via Tarantool-patches 2021-02-26 0:57 ` Vladislav Shpilevoy via Tarantool-patches 2021-02-26 7:18 ` Konstantin Osipov via Tarantool-patches 2021-02-26 20:23 ` Vladislav Shpilevoy via Tarantool-patches 2021-02-26 21:20 ` Konstantin Osipov via Tarantool-patches 2021-02-26 22:44 ` Vladislav Shpilevoy via Tarantool-patches 2021-02-27 13:27 ` Konstantin Osipov via Tarantool-patches 2021-03-01 19:15 ` Serge Petrenko via Tarantool-patches 2021-03-01 21:46 ` Konstantin Osipov via Tarantool-patches 2021-02-26 0:56 ` Vladislav Shpilevoy via Tarantool-patches 2021-03-01 19:08 ` Serge Petrenko via Tarantool-patches 2021-03-01 22:05 ` Vladislav Shpilevoy via Tarantool-patches 2021-03-02 17:51 ` Serge Petrenko via Tarantool-patches 2021-03-03 20:59 ` Vladislav Shpilevoy via Tarantool-patches 2021-03-09 15:10 ` Serge Petrenko via Tarantool-patches 2021-03-09 19:49 ` Vladislav Shpilevoy via Tarantool-patches 2021-03-10 8:18 ` Konstantin Osipov via Tarantool-patches 2021-03-12 17:10 ` Serge Petrenko via Tarantool-patches [this message] 2021-03-13 19:14 ` Konstantin Osipov via Tarantool-patches 2021-03-15 23:42 ` Vladislav Shpilevoy via Tarantool-patches 2021-03-16 6:45 ` Konstantin Osipov via Tarantool-patches 2021-03-16 20:27 ` Vladislav Shpilevoy via Tarantool-patches 2021-03-16 10:19 ` Serge Petrenko via Tarantool-patches 2021-03-16 20:48 ` Vladislav Shpilevoy via Tarantool-patches 2021-03-17 12:14 ` Serge Petrenko via Tarantool-patches 2021-03-17 21:02 ` Vladislav Shpilevoy via Tarantool-patches 2021-03-19 11:32 ` Serge Petrenko via Tarantool-patches 2021-03-19 15:36 ` Kirill Yukhin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d1179904-55ae-57ac-9454-554589d9c26d@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=gorcunov@gmail.com \ --cc=kostja.osipov@gmail.com \ --cc=sergepetrenko@tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v3] wal: introduce limits on simultaneous writes' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox