From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 347BB6F3C5; Fri, 12 Mar 2021 20:10:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 347BB6F3C5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1615569006; bh=0qOmk6CwAhbuiyM3D+sR1xGmESI9WHwsGKRj4HPwVCE=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=O02LNalDEkOxOgBnWDpeLIAY66gD7eV48nfje+fp2yMbtaUzK53mB5bBk0DbhuEY5 kFXQMqnXY5nnqy6BCcbn3pZZ1e6aPcL5qgU6gk4pM5LXQvR8qdJBicnyl6es4bKUBh R0+sOuQR6i5mhsbwgUbVOSqcbbXBhmvisPDesS3c= Received: from smtp31.i.mail.ru (smtp31.i.mail.ru [94.100.177.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0D2E16F3C5 for ; Fri, 12 Mar 2021 20:10:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0D2E16F3C5 Received: by smtp31.i.mail.ru with esmtpa (envelope-from ) id 1lKlIa-0007G0-EQ; Fri, 12 Mar 2021 20:10:04 +0300 To: Konstantin Osipov , Vladislav Shpilevoy , gorcunov@gmail.com, tarantool-patches@dev.tarantool.org References: <20210224193549.70017-1-sergepetrenko@tarantool.org> <26fde1bf-a972-fe03-fffe-818839718394@tarantool.org> <20210310081804.GA87351@starling> Message-ID: Date: Fri, 12 Mar 2021 20:10:04 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210310081804.GA87351@starling> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9D3134714A9BDB69B63430D3F1B4C5913A95494451A5CA18200894C459B0CD1B941AB717E02E6C4D5506796DB5D7DFE65BE67EF500BEF2D37261E30AE1A3D86FE X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7EED5D2FAB4CEB1EDEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637D07BBD2EBFB7BF888638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C11F5982A89E0728C9D600D5234AA1049F12CA864E7C7F319A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE767883B903EA3BAEA9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3776A0366D588B3C3117882F4460429728AD0CFFFB425014E868A13BD56FB6657D81D268191BDAD3DC09775C1D3CA48CF1664F48CFDD0DEAD76E601842F6C81A12EF20D2F80756B5F7E9C4E3C761E06A776E601842F6C81A127C277FBC8AE2E8BE57037E4920826B33AA81AA40904B5D9DBF02ECDB25306B2B25CBF701D1BE8734AD6D5ED66289B5278DA827A17800CE7E147ACFEF0AAA57B67F23339F89546C5A8DF7F3B2552694A6FED454B719173D6725E5C173C3A84C3628704EBF2E554D535872C767BF85DA2F004C906525384306FED454B719173D6462275124DF8B9C9DE2850DD75B2526BE5BFE6E7EFDEDCD789D4C264860C145E X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A24A6D60772A99906F8E1CD14B953EB46DA8868E1F87878CBB355D89D7DBCDD132 X-C1DE0DAB: 0D63561A33F958A568F8D538D25FAB0E8C67DF70204CE0522DD57C368D000125D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AC6E62257D6CD1C9FBD5A0BB2DD38791A6FC52DC45BA077DED5A9379B61CE2C08424FA1C411A92D11D7E09C32AA3244C8B15F4AA2EA9106BD1AA2859A075AE3C3FD9C8CA1B0515E0927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojQNwI24iyQ+rqK86KK8zcnQ== X-Mailru-Sender: 583F1D7ACE8F49BDD2846D59FC20E9F8CA45D6D361848145907B5B2A602F9D6DA1BFC3EE533CC8C1424AE0EB1F3D1D21E2978F233C3FAE6EE63DB1732555E4A8EE80603BA4A5B0BC112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v3] wal: introduce limits on simultaneous writes X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 10.03.2021 11:18, Konstantin Osipov пишет: > * Vladislav Shpilevoy via Tarantool-patches [21/03/09 23:44]: >> Hi! Thanks for the patch! >> >> LGTM. >> >>> https://github.com/tarantool/tarantool/issues/5536 >>> https://github.com/tarantool/tarantool/tree/sp/gh-5536-replica-oom > I don't understand why you need two parameters, size and len. What > difference does it make how many requests are in the queue? The > queue is IO and memory bound, not CPU bound, at least not more cpu > bound than any other subsystem. > > Pushing the problem to the user by forcing them to choose not one, > but two configuration values is poor design. How am I supposed to > know what is the right value for the option? After some consideration, let's only leave size. I've force pushed the changes on the branch. I've also implemented some kind of a fiber semaphore in a separate commit on top. I'm not sure I like how it turned out, so feel free to throw it away. Or keep it. > > I guess don't know it either - the patch was not followed by > a benchmark which would prove the selected defaults are optimal. > > Tarantool has an incoming throttling limit which makes the whole > system work like a clock: it's the fiber pool size and net msg > size. They were carefully selected after days and weeks of > testing. > -- Serge Petrenko