Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH luajit 0/2] Snapshot restore with stack overflow
Date: Tue, 10 Jun 2025 13:28:50 +0300	[thread overview]
Message-ID: <cover.1749550966.git.skaplun@tarantool.org> (raw)

This patchset fixes the issue with stackoverflow during the snapshot
restoration. The first patch solves the problem in the incorrect way,
since it leads to the uninitalized read. The second patch fixes the
issue correctly.

Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-1196-partial-snap-restore
Related issues:
* https://github.com/LuaJIT/LuaJIT/issues/1196
* https://github.com/tarantool/tarantool/issues/11278
Related ML link: https://www.freelists.org/post/luajit/Invalid-read-found-by-valgrind

Mike Pall (2):
  Handle partial snapshot restore due to stack overflow.
  Different fix for partial snapshot restore due to stack overflow.

 src/lj_snap.c                                 |  3 +-
 .../lj-1196-partial-snap-restore.test.lua     | 51 +++++++++++++++
 ...-1196-stack-overflow-snap-restore.test.lua | 65 +++++++++++++++++++
 3 files changed, 118 insertions(+), 1 deletion(-)
 create mode 100644 test/tarantool-tests/lj-1196-partial-snap-restore.test.lua
 create mode 100644 test/tarantool-tests/lj-1196-stack-overflow-snap-restore.test.lua

-- 
2.49.0


             reply	other threads:[~2025-06-10 10:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-10 10:28 Sergey Kaplun via Tarantool-patches [this message]
2025-06-10 10:28 ` [Tarantool-patches] [PATCH luajit 1/2] Handle partial snapshot restore due to " Sergey Kaplun via Tarantool-patches
2025-06-10 15:29   ` Sergey Bronnikov via Tarantool-patches
2025-06-10 16:03     ` Sergey Kaplun via Tarantool-patches
2025-06-10 10:28 ` [Tarantool-patches] [PATCH luajit 2/2] Different fix for " Sergey Kaplun via Tarantool-patches
2025-06-10 16:15   ` Sergey Bronnikov via Tarantool-patches
2025-06-10 16:22     ` Sergey Kaplun via Tarantool-patches
2025-06-11  9:36       ` Sergey Bronnikov via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1749550966.git.skaplun@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=sergeyb@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit 0/2] Snapshot restore with stack overflow' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox