Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH luajit 0/3] Fix descriptor leak in loadfile
Date: Thu,  5 Jun 2025 08:44:17 +0300	[thread overview]
Message-ID: <cover.1749101434.git.skaplun@tarantool.org> (raw)

This patch set fixes the possible descriptor leak in the `loadfile()`
in case of the error.
The first patch adds the Valgrind configuration to the corresponding CI
workflow to test the descriptor leakage.
The last two fix two similar scenarios of the leak.

Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-1249-loadfile-fd-leak
Related issues:
* https://github.com/LuaJIT/LuaJIT/issues/1249
* https://github.com/tarantool/tarantool/issues/11278

Mike Pall (2):
  Fix potential file descriptor leak in luaL_loadfile*().
  Fix another potential file descriptor leak in luaL_loadfile*().

Sergey Kaplun (1):
  ci: add track-fds Valgrind scenario

 .github/workflows/valgrind-testing.yaml       |  9 ++-
 src/lj_load.c                                 | 19 +++---
 .../lj-1249-loadfile-fd-leak.test.lua         | 59 +++++++++++++++++++
 test/tarantool-tests/utils/CMakeLists.txt     |  1 +
 4 files changed, 78 insertions(+), 10 deletions(-)
 create mode 100644 test/tarantool-tests/lj-1249-loadfile-fd-leak.test.lua

-- 
2.49.0


             reply	other threads:[~2025-06-05  5:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-05  5:44 Sergey Kaplun via Tarantool-patches [this message]
2025-06-05  5:44 ` [Tarantool-patches] [PATCH luajit 1/3] ci: add track-fds Valgrind scenario Sergey Kaplun via Tarantool-patches
2025-06-06 13:56   ` Sergey Bronnikov via Tarantool-patches
2025-06-06 14:03     ` Sergey Kaplun via Tarantool-patches
2025-06-06 14:54       ` Sergey Bronnikov via Tarantool-patches
2025-06-06 15:31         ` Sergey Kaplun via Tarantool-patches
2025-06-05  5:44 ` [Tarantool-patches] [PATCH luajit 2/3] Fix potential file descriptor leak in luaL_loadfile*() Sergey Kaplun via Tarantool-patches
2025-06-06 14:47   ` Sergey Bronnikov via Tarantool-patches
2025-06-06 15:14     ` Sergey Kaplun via Tarantool-patches
2025-06-06 15:49       ` Sergey Bronnikov via Tarantool-patches
2025-06-05  5:44 ` [Tarantool-patches] [PATCH luajit 3/3] Fix another " Sergey Kaplun via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1749101434.git.skaplun@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=sergeyb@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit 0/3] Fix descriptor leak in loadfile' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox