Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH luajit 0/4] Fixes for load fusing optimization
Date: Fri, 10 Jan 2025 16:07:43 +0300	[thread overview]
Message-ID: <cover.1736509260.git.skaplun@tarantool.org> (raw)

The patch set fixes load fusing optimization by preventing it across:
* `table.clear()` (1st, 2nd, 4th commits)
* `IR_NEWREF` (3rd commit)

Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-1117-loads-fusion
Related issues:
* https://github.com/LuaJIT/LuaJIT/issues/1117
* https://github.com/tarantool/tarantool/issues/10709

Mike Pall (4):
  x86/x64: Don't fuse loads across table.clear.
  Improve last commit.
  x86/x64: Don't fuse loads across IR_NEWREF.
  Fix last commit.

 src/lj_asm_x86.h                              | 16 +++---
 .../lj-1117-fuse-across-newref.test.lua       | 52 +++++++++++++++++++
 .../lj-1117-fuse-across-table-clear.test.lua  | 36 +++++++++++++
 3 files changed, 97 insertions(+), 7 deletions(-)
 create mode 100644 test/tarantool-tests/lj-1117-fuse-across-newref.test.lua
 create mode 100644 test/tarantool-tests/lj-1117-fuse-across-table-clear.test.lua

-- 
2.47.1


             reply	other threads:[~2025-01-10 13:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-10 13:07 Sergey Kaplun via Tarantool-patches [this message]
2025-01-10 13:07 ` [Tarantool-patches] [PATCH luajit 1/4] x86/x64: Don't fuse loads across table.clear Sergey Kaplun via Tarantool-patches
2025-01-14 14:10   ` Sergey Bronnikov via Tarantool-patches
2025-01-10 13:07 ` [Tarantool-patches] [PATCH luajit 2/4] Improve last commit Sergey Kaplun via Tarantool-patches
2025-01-14 14:11   ` Sergey Bronnikov via Tarantool-patches
2025-01-10 13:07 ` [Tarantool-patches] [PATCH luajit 3/4] x86/x64: Don't fuse loads across IR_NEWREF Sergey Kaplun via Tarantool-patches
2025-01-14 14:15   ` Sergey Bronnikov via Tarantool-patches
2025-01-10 13:07 ` [Tarantool-patches] [PATCH luajit 4/4] Fix last commit Sergey Kaplun via Tarantool-patches
2025-01-14 14:15   ` Sergey Bronnikov via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1736509260.git.skaplun@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=sergeyb@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit 0/4] Fixes for load fusing optimization' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox