Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maxim Kokryashkin <m.kokryashkin@tarantool.org>,
	Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH luajit 0/2] Use ptrace for sysprof tests
Date: Tue, 28 Nov 2023 14:53:15 +0000	[thread overview]
Message-ID: <cover.1701182592.git.imun@tarantool.org> (raw)

Hello there,

The latter patch of the patchset provides the new approach for
deterministic testing for our sampling profiler. See more info in the
commit message.

The first patch fixes the issue occurred while reimplementing the
sysprof test via fork(3) + ptrace(2): the output for prove was buffered
and hence duplicated when fork is done. I decided to turn of buffering
at all, since there is little sense in it for tests and nobody wants to
debug many (still unrevealed) related problems.

I hope the approach will be moved to our utils for tests written in C,
but I do not see the whole picture at the moment, so the approach is
implemented for the only test being affected by the patch for #8594.

Branch: https://github.com/tarantool/luajit/commits/imun/sysprof-ptrace-ffunc-test
CI: https://github.com/tarantool/luajit/commit/b48b905
Tarantool CI: https://github.com/tarantool/tarantool/pull/9424
Related issues:
* https://github.com/tarantool/tarantool/issues/9387
* https://github.com/tarantool/tarantool/issues/8594
* https://github.com/tarantool/tarantool/issues/7900

Igor Munkin (2):
  test: disable buffering for the C test engine
  test: rewrite sysprof test using managed execution

 .../gh-8594-sysprof-ffunc-crash.test.c        | 269 ++++++++++++++++++
 test/tarantool-c-tests/test.c                 |   6 +
 .../gh-8594-sysprof-ffunc-crash.test.lua      |  55 ----
 3 files changed, 275 insertions(+), 55 deletions(-)
 create mode 100644 test/tarantool-c-tests/gh-8594-sysprof-ffunc-crash.test.c
 delete mode 100644 test/tarantool-tests/gh-8594-sysprof-ffunc-crash.test.lua

-- 
2.39.2


             reply	other threads:[~2023-11-28 14:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-28 14:53 Igor Munkin via Tarantool-patches [this message]
2023-11-28 14:53 ` [Tarantool-patches] [PATCH luajit 1/2] test: disable buffering for the C test engine Igor Munkin via Tarantool-patches
2023-12-03 12:25   ` Maxim Kokryashkin via Tarantool-patches
2023-12-04  9:48     ` Igor Munkin via Tarantool-patches
2023-12-04  8:46   ` Sergey Kaplun via Tarantool-patches
2023-12-04  9:50     ` Igor Munkin via Tarantool-patches
2023-11-28 14:53 ` [Tarantool-patches] [PATCH luajit 2/2] test: rewrite sysprof test using managed execution Igor Munkin via Tarantool-patches
2023-12-03 14:17   ` Maxim Kokryashkin via Tarantool-patches
2023-12-05  8:37     ` Sergey Kaplun via Tarantool-patches
2023-12-05 12:04       ` Igor Munkin via Tarantool-patches
2023-12-05 12:25         ` Sergey Kaplun via Tarantool-patches
2023-12-05 12:59           ` Igor Munkin via Tarantool-patches
2023-12-05 15:08             ` Sergey Kaplun via Tarantool-patches
2023-12-05 11:34     ` Igor Munkin via Tarantool-patches
2023-12-05 13:23       ` Maxim Kokryashkin via Tarantool-patches
2023-11-28 16:14 ` [Tarantool-patches] [PATCH luajit 0/2] Use ptrace for sysprof tests Sergey Bronnikov via Tarantool-patches
2024-01-10  8:50 ` Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1701182592.git.imun@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=m.kokryashkin@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit 0/2] Use ptrace for sysprof tests' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox