Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maxim Kokryashkin <m.kokryashkin@tarantool.org>,
	Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH luajit 0/3] Fix fix-mips64-spare-side-exit-patching
Date: Mon,  4 Sep 2023 18:50:23 +0300	[thread overview]
Message-ID: <cover.1693840653.git.skaplun@tarantool.org> (raw)

This patchset includes 3 pathes to make our tests great again:
1) 'MIPS: Fix "bad FP FLOAD" assertion.' is needed for easier testing
   the patch's correctness (that test still reproduces the problem on
   MIPS). The patch itself is trivial, as is the test for it.
2) 'test: fix `fillmcode()` generator helper' fixes the correctness of
   fillmcode logic -- somehow the condition of `while` cycle for mcode
   generation was inverted.
3) 'test: fix fix-mips64-spare-side-exit-patching' fixes the possible
   misbehaviours in the test itself (they were more likely observed before
   the second patch but still needed to be fixed).

Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-fix-flaky-mips-spare-exit
Tarantool PR: https://github.com/tarantool/tarantool/pull/9090
Related issues for the first patch:
* https://github.com/LuaJIT/LuaJIT/issues/1043
* https://github.com/tarantool/tarantool/issues/8825

Mike Pall (1):
  MIPS: Fix "bad FP FLOAD" assertion.

Sergey Kaplun (2):
  test: fix `fillmcode()` generator helper
  test: fix fix-mips64-spare-side-exit-patching

 src/lj_asm_mips.h                             |  2 +-
 ...x-mips64-spare-side-exit-patching.test.lua | 22 ++++++++++++++---
 .../lj-1043-asm-fload.test.lua                | 24 +++++++++++++++++++
 test/tarantool-tests/utils/jit/generators.lua |  7 +++---
 4 files changed, 47 insertions(+), 8 deletions(-)
 create mode 100644 test/tarantool-tests/lj-1043-asm-fload.test.lua


             reply	other threads:[~2023-09-04 15:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-04 15:50 Sergey Kaplun via Tarantool-patches [this message]
2023-09-04 15:50 ` [Tarantool-patches] [PATCH luajit 1/3] MIPS: Fix "bad FP FLOAD" assertion Sergey Kaplun via Tarantool-patches
2023-09-05  7:05   ` Maxim Kokryashkin via Tarantool-patches
2023-09-26 18:58   ` Igor Munkin via Tarantool-patches
2023-09-04 15:50 ` [Tarantool-patches] [PATCH luajit 2/3] test: fix `fillmcode()` generator helper Sergey Kaplun via Tarantool-patches
2023-09-05  7:06   ` Maxim Kokryashkin via Tarantool-patches
2023-09-26 18:58   ` Igor Munkin via Tarantool-patches
2023-09-04 15:50 ` [Tarantool-patches] [PATCH luajit 3/3] test: fix fix-mips64-spare-side-exit-patching Sergey Kaplun via Tarantool-patches
2023-09-05  8:56   ` Maxim Kokryashkin via Tarantool-patches
2023-09-05 11:16     ` Sergey Kaplun via Tarantool-patches
2023-09-26 18:59   ` Igor Munkin via Tarantool-patches
2023-09-27 12:33 ` [Tarantool-patches] [PATCH luajit 0/3] Fix fix-mips64-spare-side-exit-patching Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1693840653.git.skaplun@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=m.kokryashkin@tarantool.org \
    --cc=sergeyb@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit 0/3] Fix fix-mips64-spare-side-exit-patching' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox