Re: [Tarantool-patches] [PATCH luajit 0/3] Fix fix-mips64-spare-side-exit-patching

[Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Sergey,

I've checked the patchset into all long-term branches in
tarantool/luajit and bumped a new version in master, release/2.11 and
release/2.10.

On 04.09.23, Sergey Kaplun via Tarantool-patches wrote:
> This patchset includes 3 pathes to make our tests great again:
> 1) 'MIPS: Fix "bad FP FLOAD" assertion.' is needed for easier testing
>    the patch's correctness (that test still reproduces the problem on
>    MIPS). The patch itself is trivial, as is the test for it.
> 2) 'test: fix `fillmcode()` generator helper' fixes the correctness of
>    fillmcode logic -- somehow the condition of `while` cycle for mcode
>    generation was inverted.
> 3) 'test: fix fix-mips64-spare-side-exit-patching' fixes the possible
>    misbehaviours in the test itself (they were more likely observed before
>    the second patch but still needed to be fixed).
> 
> Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-fix-flaky-mips-spare-exit
> Tarantool PR: https://github.com/tarantool/tarantool/pull/9090
> Related issues for the first patch:
> * https://github.com/LuaJIT/LuaJIT/issues/1043
> * https://github.com/tarantool/tarantool/issues/8825
> 
> Mike Pall (1):
>   MIPS: Fix "bad FP FLOAD" assertion.
> 
> Sergey Kaplun (2):
>   test: fix `fillmcode()` generator helper
>   test: fix fix-mips64-spare-side-exit-patching
> 
>  src/lj_asm_mips.h                             |  2 +-
>  ...x-mips64-spare-side-exit-patching.test.lua | 22 ++++++++++++++---
>  .../lj-1043-asm-fload.test.lua                | 24 +++++++++++++++++++
>  test/tarantool-tests/utils/jit/generators.lua |  7 +++---
>  4 files changed, 47 insertions(+), 8 deletions(-)
>  create mode 100644 test/tarantool-tests/lj-1043-asm-fload.test.lua
> 
> -- 
> 2.42.0
> 

-- 
Best regards,
IM