From: Mergen Imeev via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: v.shpilevoy@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v4 00/16] sql: refactor aggregate functions
Date: Fri, 1 Oct 2021 15:48:29 +0300 [thread overview]
Message-ID: <cover.1633092363.git.imeevma@gmail.com> (raw)
This patch-set refactor the aggregate functions and does some refactoring of the
SQL function infrastructure as a whole.
https://github.com/tarantool/tarantool/issues/4145
https://github.com/tarantool/tarantool/tree/imeevma/gh-4145-aggregate-functions
Changes in v2:
- Added commit to remove possible UB in int-to-double implicit cast function.
- Added commit to drop argv from struct sql_context.
- Review fixes.
Changes in v3:
- All functional changes were carried over from this patch-set. All that's left
is refactoring.
Changes in v4:
- Zeroblob optimization was removed, which allowed to simplify code and avoid
some errors.
Mergen Imeev (16):
sql: remove MEM_Zero flag from struct MEM
sql: fix possible undefined behavior during cast
sql: use register P1 for number of arguments
sql: remove AggStep0 and OP_BuiltinFunction0
sql: move collation to struct sql_context
sql: introduce mem_append()
sql: remove sql_vdbemem_finalize()
sql: refactor SUM() function
sql: refactor TOTAL() function
sql: refactor AVG() function
sql: refactor COUNT() function
sql: refactor MIN() and MAX() functions
sql: refactor GROUP_CONCAT() function
sql: remove copying of result in finalizers
sql: remove MEM_TYPE_AGG
sql: remove field argv from struct sql_context
src/box/sql/date.c | 43 ---
src/box/sql/expr.c | 19 +-
src/box/sql/func.c | 812 +++++++++++++++++++-----------------------
src/box/sql/main.c | 5 +-
src/box/sql/mem.c | 200 ++---------
src/box/sql/mem.h | 51 +--
src/box/sql/select.c | 35 +-
src/box/sql/sqlInt.h | 40 +--
src/box/sql/vdbe.c | 202 ++---------
src/box/sql/vdbeInt.h | 7 +-
src/box/sql/vdbeapi.c | 108 ------
src/box/sql/vdbeaux.c | 21 +-
12 files changed, 504 insertions(+), 1039 deletions(-)
--
2.25.1
next reply other threads:[~2021-10-01 12:48 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 12:48 Mergen Imeev via Tarantool-patches [this message]
2021-10-01 12:48 ` [Tarantool-patches] [PATCH v4 01/16] sql: remove MEM_Zero flag from struct MEM Mergen Imeev via Tarantool-patches
2021-10-04 21:51 ` Vladislav Shpilevoy via Tarantool-patches
2021-10-05 8:46 ` Mergen Imeev via Tarantool-patches
2021-10-05 9:42 ` Mergen Imeev via Tarantool-patches
2021-10-05 12:28 ` Mergen Imeev via Tarantool-patches
2021-10-01 12:48 ` [Tarantool-patches] [PATCH v4 02/16] sql: fix possible undefined behavior during cast Mergen Imeev via Tarantool-patches
2021-10-04 21:52 ` Vladislav Shpilevoy via Tarantool-patches
2021-10-05 9:00 ` Mergen Imeev via Tarantool-patches
2021-10-01 12:48 ` [Tarantool-patches] [PATCH v4 03/16] sql: use register P1 for number of arguments Mergen Imeev via Tarantool-patches
2021-10-01 12:48 ` [Tarantool-patches] [PATCH v4 04/16] sql: remove AggStep0 and OP_BuiltinFunction0 Mergen Imeev via Tarantool-patches
2021-10-01 12:48 ` [Tarantool-patches] [PATCH v4 05/16] sql: move collation to struct sql_context Mergen Imeev via Tarantool-patches
2021-10-01 12:48 ` [Tarantool-patches] [PATCH v4 06/16] sql: introduce mem_append() Mergen Imeev via Tarantool-patches
2021-10-04 21:52 ` Vladislav Shpilevoy via Tarantool-patches
2021-10-05 9:32 ` Mergen Imeev via Tarantool-patches
2021-10-11 21:50 ` Vladislav Shpilevoy via Tarantool-patches
2021-10-19 10:49 ` Mergen Imeev via Tarantool-patches
2021-10-01 12:48 ` [Tarantool-patches] [PATCH v4 07/16] sql: remove sql_vdbemem_finalize() Mergen Imeev via Tarantool-patches
2021-10-01 12:48 ` [Tarantool-patches] [PATCH v4 08/16] sql: refactor SUM() function Mergen Imeev via Tarantool-patches
2021-10-01 12:48 ` [Tarantool-patches] [PATCH v4 09/16] sql: refactor TOTAL() function Mergen Imeev via Tarantool-patches
2021-10-01 12:48 ` [Tarantool-patches] [PATCH v4 10/16] sql: refactor AVG() function Mergen Imeev via Tarantool-patches
2021-10-04 21:53 ` Vladislav Shpilevoy via Tarantool-patches
2021-10-05 9:48 ` Mergen Imeev via Tarantool-patches
2021-10-11 21:50 ` Vladislav Shpilevoy via Tarantool-patches
2021-10-19 11:14 ` Mergen Imeev via Tarantool-patches
2021-10-01 12:48 ` [Tarantool-patches] [PATCH v4 11/16] sql: refactor COUNT() function Mergen Imeev via Tarantool-patches
2021-10-04 21:53 ` Vladislav Shpilevoy via Tarantool-patches
2021-10-05 9:55 ` Mergen Imeev via Tarantool-patches
2021-10-11 21:51 ` Vladislav Shpilevoy via Tarantool-patches
2021-10-19 11:17 ` Mergen Imeev via Tarantool-patches
2021-10-01 12:48 ` [Tarantool-patches] [PATCH v4 12/16] sql: refactor MIN() and MAX() functions Mergen Imeev via Tarantool-patches
2021-10-04 21:54 ` Vladislav Shpilevoy via Tarantool-patches
2021-10-05 10:07 ` Mergen Imeev via Tarantool-patches
2021-10-01 12:48 ` [Tarantool-patches] [PATCH v4 13/16] sql: refactor GROUP_CONCAT() function Mergen Imeev via Tarantool-patches
2021-10-01 12:48 ` [Tarantool-patches] [PATCH v4 14/16] sql: remove copying of result in finalizers Mergen Imeev via Tarantool-patches
2021-10-01 12:48 ` [Tarantool-patches] [PATCH v4 15/16] sql: remove MEM_TYPE_AGG Mergen Imeev via Tarantool-patches
2021-10-01 12:49 ` [Tarantool-patches] [PATCH v4 16/16] sql: remove field argv from struct sql_context Mergen Imeev via Tarantool-patches
2021-10-25 20:58 ` [Tarantool-patches] [PATCH v4 00/16] sql: refactor aggregate functions Vladislav Shpilevoy via Tarantool-patches
2021-10-26 10:34 Mergen Imeev via Tarantool-patches
2021-11-02 10:36 ` Kirill Yukhin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1633092363.git.imeevma@gmail.com \
--to=tarantool-patches@dev.tarantool.org \
--cc=imeevma@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v4 00/16] sql: refactor aggregate functions' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox