From: Oleg Babin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: v.shpilevoy@tarantool.org, imun@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v3 0/4] fiber: keep reference to userdata if fiber created once
Date: Fri, 3 Sep 2021 23:49:14 +0300 [thread overview]
Message-ID: <cover.1630701714.git.babinoleg@mail.ru> (raw)
From: Oleg Babin <babinoleg@mail.ru>
This patch reworks approach to fiber management in Lua. Before
this patch each action that should return fiber led to new
userdata creation that was quite slow and made GC suffer. This
patch introduces new field in struct fiber to store a reference to
userdata that was created once for a fiber. It allows speedup
operations as fiber.self() and fiber.id().
Simple benchmark shows that access to fiber storage is faster in
two times, fiber.find() - 2-3 times and fiber.new/create functions
don't have any changes.
Initially changes were inspired by #6210 [1] but current patchset
doesn't introduce anything new just improves performance of
existing functions.
Some results are available also in related github PR [2].
[1] https://github.com/tarantool/tarantool/issues/6210
[2] https://github.com/tarantool/tarantool/pull/6280
Changes in v3:
- Review fixes by Igor
- New patch to make public LUA_NOREF value
Changes in v2:
- Review fixes by Vlad and Igor
- The patch patch that introduced mempool usage is discarded
Oleg Babin (4):
fiber: rename ref to storage_ref
fiber: pass struct fiber into lbox_pushfiber instead of id
lua/utils: make LUA_NOREF value public
fiber: keep reference to userdata if fiber created once
src/lib/core/fiber.c | 5 ++
src/lib/core/fiber.h | 7 +-
src/lua/fiber.c | 124 ++++++++++++------------------------
src/lua/utils.c | 1 +
test/unit/core_test_utils.c | 2 +
5 files changed, 53 insertions(+), 86 deletions(-)
--
2.32.0
next reply other threads:[~2021-09-03 20:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 20:49 Oleg Babin via Tarantool-patches [this message]
2021-09-03 20:49 ` [Tarantool-patches] [PATCH v3 1/4] fiber: rename ref to storage_ref Oleg Babin via Tarantool-patches
2021-09-03 20:49 ` [Tarantool-patches] [PATCH v3 2/4] fiber: pass struct fiber into lbox_pushfiber instead of id Oleg Babin via Tarantool-patches
2021-09-03 20:49 ` [Tarantool-patches] [PATCH v3 3/4] lua/utils: make LUA_NOREF value public Oleg Babin via Tarantool-patches
2021-09-03 20:49 ` [Tarantool-patches] [PATCH v3 4/4] fiber: keep reference to userdata if fiber created once Oleg Babin via Tarantool-patches
2021-09-07 21:43 ` [Tarantool-patches] [PATCH v3 0/4] " Vladislav Shpilevoy via Tarantool-patches
2021-09-08 12:54 ` Oleg Babin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1630701714.git.babinoleg@mail.ru \
--to=tarantool-patches@dev.tarantool.org \
--cc=imun@tarantool.org \
--cc=olegrok@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v3 0/4] fiber: keep reference to userdata if fiber created once' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox