Tarantool development patches archive
 help / color / mirror / Atom feed
From: Mergen Imeev via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: kyukhin@tarantool.org, v.ioffe@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v1 0/9] Check types of SQL built-in functions arguments
Date: Thu, 19 Aug 2021 15:02:54 +0300	[thread overview]
Message-ID: <cover.1629374448.git.imeevma@gmail.com> (raw)

This patch introduces static and dynamic type checks for SQL built-in functions.

https://github.com/tarantool/tarantool/issues/6105
https://github.com/tarantool/tarantool/tree/imeevma/gh-6105-properly-check-funcs-args-types

Mergen Imeev (9):
  sql: modify signature of TRIM()
  sql: rework SQL built-in functions hash table
  sql: check number of arguments during parsing
  sql: static type check for SQL built-in functions
  sql: runtime type check for SQL built-in functions
  sql: enable types checking for some functions
  sql: fix result type of min() and max() functions
  sql: check argument types of sum(), avg(), total()
  sql: arguments check for string value functions

 .../gh-6105-built-in-functions-args.md        |    6 +
 src/box/sql/expr.c                            |   36 +-
 src/box/sql/func.c                            | 1339 +++++++----------
 src/box/sql/mem.c                             |    2 +-
 src/box/sql/parse.y                           |   36 +-
 src/box/sql/prepare.c                         |    2 +-
 src/box/sql/resolve.c                         |   44 +-
 src/box/sql/select.c                          |   10 +-
 src/box/sql/sqlInt.h                          |   13 +
 test/sql-tap/aggnested.test.lua               |    8 +-
 test/sql-tap/badutf1.test.lua                 |   34 +-
 test/sql-tap/built-in-functions.test.lua      |  548 +++++++
 test/sql-tap/coalesce.test.lua                |    2 +-
 test/sql-tap/cse.test.lua                     |    8 +-
 test/sql-tap/distinctagg.test.lua             |    3 +-
 test/sql-tap/e_select1.test.lua               |   30 +-
 test/sql-tap/engine.cfg                       |    3 +
 test/sql-tap/func.test.lua                    |  213 +--
 test/sql-tap/func2.test.lua                   |   18 +-
 test/sql-tap/func5.test.lua                   |    6 +-
 .../gh-6299-lost-collation-on-trim.test.lua   |   47 +
 test/sql-tap/minmax2.test.lua                 |    5 +-
 test/sql-tap/minmax4.test.lua                 |    2 +-
 test/sql-tap/null.test.lua                    |    2 +-
 test/sql-tap/orderby1.test.lua                |    2 +-
 test/sql-tap/position.test.lua                |   84 +-
 test/sql-tap/select1.test.lua                 |    4 +-
 test/sql-tap/select3.test.lua                 |   16 +-
 test/sql-tap/select5.test.lua                 |    2 +-
 test/sql-tap/select6.test.lua                 |   21 +-
 test/sql-tap/selectG.test.lua                 |    2 +-
 test/sql-tap/sql-errors.test.lua              |    2 +-
 test/sql-tap/subquery.test.lua                |    8 +-
 test/sql-tap/substr.test.lua                  |    6 +-
 test/sql-tap/tkt2942.test.lua                 |   10 +-
 test/sql-tap/uuid.test.lua                    |   86 +-
 test/sql-tap/view.test.lua                    |    2 +-
 test/sql-tap/where3.test.lua                  |    6 +-
 test/sql-tap/with1.test.lua                   |    2 +-
 test/sql/boolean.result                       |   45 +-
 test/sql/collation.result                     |    2 +-
 test/sql/iproto.result                        |    4 +-
 test/sql/max-on-index.result                  |    6 +-
 test/sql/prepared.result                      |   12 +-
 test/sql/prepared.test.lua                    |    2 +-
 test/sql/types.result                         |  122 +-
 46 files changed, 1498 insertions(+), 1365 deletions(-)
 create mode 100644 changelogs/unreleased/gh-6105-built-in-functions-args.md
 create mode 100755 test/sql-tap/built-in-functions.test.lua
 create mode 100755 test/sql-tap/gh-6299-lost-collation-on-trim.test.lua

-- 
2.25.1


             reply	other threads:[~2021-08-19 12:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-19 12:02 Mergen Imeev via Tarantool-patches [this message]
2021-08-19 12:02 ` [Tarantool-patches] [PATCH v1 1/9] sql: modify signature of TRIM() Mergen Imeev via Tarantool-patches
2021-08-19 12:02 ` [Tarantool-patches] [PATCH v1 2/9] sql: rework SQL built-in functions hash table Mergen Imeev via Tarantool-patches
2021-08-19 12:03 ` [Tarantool-patches] [PATCH v1 3/9] sql: check number of arguments during parsing Mergen Imeev via Tarantool-patches
2021-08-19 12:03 ` [Tarantool-patches] [PATCH v1 4/9] sql: static type check for SQL built-in functions Mergen Imeev via Tarantool-patches
2021-08-19 12:03 ` [Tarantool-patches] [PATCH v1 5/9] sql: runtime " Mergen Imeev via Tarantool-patches
2021-08-19 12:03 ` [Tarantool-patches] [PATCH v1 6/9] sql: enable types checking for some functions Mergen Imeev via Tarantool-patches
2021-08-19 12:03 ` [Tarantool-patches] [PATCH v1 7/9] sql: fix result type of min() and max() functions Mergen Imeev via Tarantool-patches
2021-08-19 12:03 ` [Tarantool-patches] [PATCH v1 8/9] sql: check argument types of sum(), avg(), total() Mergen Imeev via Tarantool-patches
2021-08-19 12:03 ` [Tarantool-patches] [PATCH v1 9/9] sql: arguments check for string value functions Mergen Imeev via Tarantool-patches
2021-08-19 12:26 ` [Tarantool-patches] [PATCH v1 0/9] Check types of SQL built-in functions arguments Kirill Yukhin via Tarantool-patches
2021-08-19 15:50   ` Vitaliia Ioffe via Tarantool-patches
2021-08-19 16:16 ` Kirill Yukhin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1629374448.git.imeevma@gmail.com \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imeevma@tarantool.org \
    --cc=kyukhin@tarantool.org \
    --cc=v.ioffe@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v1 0/9] Check types of SQL built-in functions arguments' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox