From: Vitaliia Ioffe via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: "Kirill Yukhin" <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 0/9] Check types of SQL built-in functions arguments
Date: Thu, 19 Aug 2021 18:50:59 +0300 [thread overview]
Message-ID: <1629388259.258705469@f713.i.mail.ru> (raw)
In-Reply-To: <20210819122642.b5pvtli465gse5l2@tarantool.org>
[-- Attachment #1: Type: text/plain, Size: 1027 bytes --]
Cause osx_10_15_lto was passed this is my QA LGTM on the last patch
Hooray!
--
Vitaliia Ioffe
>Четверг, 19 августа 2021, 15:26 +03:00 от Kirill Yukhin <kyukhin@tarantool.org>:
>
>Hello,
>
>On 19 авг 15:02, imeevma@tarantool.org wrote:
>> This patch introduces static and dynamic type checks for SQL built-in functions.
>>
>> https://github.com/tarantool/tarantool/issues/6105
>> https://github.com/tarantool/tarantool/tree/imeevma/gh-6105-properly-check-funcs-args-types
>>
>> Mergen Imeev (9):
>> sql: modify signature of TRIM()
>> sql: rework SQL built-in functions hash table
>> sql: check number of arguments during parsing
>> sql: static type check for SQL built-in functions
>> sql: runtime type check for SQL built-in functions
>> sql: enable types checking for some functions
>> sql: fix result type of min() and max() functions
>> sql: check argument types of sum(), avg(), total()
>> sql: arguments check for string value functions
>LGTM.
>
>--
>Regards, Kirill Yukhin
[-- Attachment #2: Type: text/html, Size: 1876 bytes --]
next prev parent reply other threads:[~2021-08-19 15:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 12:02 Mergen Imeev via Tarantool-patches
2021-08-19 12:02 ` [Tarantool-patches] [PATCH v1 1/9] sql: modify signature of TRIM() Mergen Imeev via Tarantool-patches
2021-08-19 12:02 ` [Tarantool-patches] [PATCH v1 2/9] sql: rework SQL built-in functions hash table Mergen Imeev via Tarantool-patches
2021-08-19 12:03 ` [Tarantool-patches] [PATCH v1 3/9] sql: check number of arguments during parsing Mergen Imeev via Tarantool-patches
2021-08-19 12:03 ` [Tarantool-patches] [PATCH v1 4/9] sql: static type check for SQL built-in functions Mergen Imeev via Tarantool-patches
2021-08-19 12:03 ` [Tarantool-patches] [PATCH v1 5/9] sql: runtime " Mergen Imeev via Tarantool-patches
2021-08-19 12:03 ` [Tarantool-patches] [PATCH v1 6/9] sql: enable types checking for some functions Mergen Imeev via Tarantool-patches
2021-08-19 12:03 ` [Tarantool-patches] [PATCH v1 7/9] sql: fix result type of min() and max() functions Mergen Imeev via Tarantool-patches
2021-08-19 12:03 ` [Tarantool-patches] [PATCH v1 8/9] sql: check argument types of sum(), avg(), total() Mergen Imeev via Tarantool-patches
2021-08-19 12:03 ` [Tarantool-patches] [PATCH v1 9/9] sql: arguments check for string value functions Mergen Imeev via Tarantool-patches
2021-08-19 12:26 ` [Tarantool-patches] [PATCH v1 0/9] Check types of SQL built-in functions arguments Kirill Yukhin via Tarantool-patches
2021-08-19 15:50 ` Vitaliia Ioffe via Tarantool-patches [this message]
2021-08-19 16:16 ` Kirill Yukhin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1629388259.258705469@f713.i.mail.ru \
--to=tarantool-patches@dev.tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=v.ioffe@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1 0/9] Check types of SQL built-in functions arguments' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox