From: Mergen Imeev via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: tsafin@tarantool.org Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH v2 0/3] Fix explicit casts Date: Fri, 30 Jul 2021 10:11:49 +0300 [thread overview] Message-ID: <cover.1627628984.git.imeevma@gmail.com> (raw) This patch fixes the explicit cast to comply with the new rules. According to these rules, BOOLEAN and VARBINARY values can no longer be cast to numeric types, and numeric values can no longer be cast to BOOLEAN. https://github.com/tarantool/tarantool/issues/4470 https://github.com/tarantool/tarantool/tree/imeevma/gh-4470-fix-explicit-cast Changes in v2: - Change of str_to_bool() were moved in new patch. Mergen Imeev (3): sql: disallow explicit cast of BOOLEAN to number sql: disallow explicit cast of VARBINARY to number sql: fix STRING to BOOLEAN explicit cast .../unreleased/gh-4470-explicit-cast.md | 8 + src/box/sql/mem.c | 98 +++------ test/sql-tap/cast.test.lua | 186 +++++++++++++++--- test/sql-tap/cse.test.lua | 18 +- test/sql-tap/e_select1.test.lua | 3 +- ...-4766-wrong-cast-from-blob-to-int.test.lua | 40 ---- test/sql-tap/in1.test.lua | 17 +- test/sql-tap/misc3.test.lua | 2 +- test/sql-tap/numcast.test.lua | 18 +- test/sql/boolean.result | 71 +++---- test/sql/boolean.test.sql | 13 +- test/sql/types.result | 14 +- 12 files changed, 271 insertions(+), 217 deletions(-) create mode 100644 changelogs/unreleased/gh-4470-explicit-cast.md delete mode 100755 test/sql-tap/gh-4766-wrong-cast-from-blob-to-int.test.lua -- 2.25.1
next reply other threads:[~2021-07-30 7:11 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-30 7:11 Mergen Imeev via Tarantool-patches [this message] 2021-07-30 7:11 ` [Tarantool-patches] [PATCH v2 1/3] sql: disallow explicit cast of BOOLEAN to number Mergen Imeev via Tarantool-patches 2021-07-30 7:11 ` [Tarantool-patches] [PATCH v2 2/3] sql: disallow explicit cast of VARBINARY " Mergen Imeev via Tarantool-patches 2021-07-30 7:11 ` [Tarantool-patches] [PATCH v2 3/3] sql: fix STRING to BOOLEAN explicit cast Mergen Imeev via Tarantool-patches -- strict thread matches above, loose matches on Subject: below -- 2021-08-04 8:32 [Tarantool-patches] [PATCH v2 0/3] Fix explicit casts Mergen Imeev via Tarantool-patches 2021-08-04 14:16 ` Kirill Yukhin via Tarantool-patches 2021-08-04 15:21 ` Vitaliia Ioffe via Tarantool-patches 2021-08-05 9:48 ` Kirill Yukhin via Tarantool-patches 2021-08-02 17:25 Mergen Imeev via Tarantool-patches 2021-07-27 11:31 Mergen Imeev via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1627628984.git.imeevma@gmail.com \ --to=tarantool-patches@dev.tarantool.org \ --cc=imeevma@tarantool.org \ --cc=tsafin@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v2 0/3] Fix explicit casts' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox