Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vitaliia Ioffe via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches]  [PATCH v2 0/3] Fix explicit casts
Date: Wed, 04 Aug 2021 18:21:59 +0300	[thread overview]
Message-ID: <1628090519.890717629@f392.i.mail.ru> (raw)
In-Reply-To: <20210804141625.krom7aukl3pfe7kk@tarantool.org>

[-- Attachment #1: Type: text/plain, Size: 846 bytes --]


 
Hi,  
 
QA LGTM
 
--
Vitaliia Ioffe
 
  
>Среда, 4 августа 2021, 17:16 +03:00 от Kirill Yukhin via Tarantool-patches <tarantool-patches@dev.tarantool.org>:
> 
>Hello,
>
>On 04 авг 11:32,  imeevma@tarantool.org wrote:
>> This patch fixes the explicit cast to comply with the new rules. According to
>> these rules, BOOLEAN and VARBINARY can no longer be cast to numeric types.
>>
>>  https://github.com/tarantool/tarantool/issues/4470
>>  https://github.com/tarantool/tarantool/tree/imeevma/gh-4470-fix-explicit-cast
>>
>> Changes in v2:
>> - Change of str_to_bool() were moved in new patch.
>>
>> Mergen Imeev (3):
>> sql: disallow explicit cast of BOOLEAN to number
>> sql: disallow explicit cast of VARBINARY to number
>> sql: fix STRING to BOOLEAN explicit cast
>The patch set LGTM.
>
>--
>Regards, Kirill Yukhin
 

[-- Attachment #2: Type: text/html, Size: 1657 bytes --]

  reply	other threads:[~2021-08-04 15:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-04  8:32 Mergen Imeev via Tarantool-patches
2021-08-04  8:32 ` [Tarantool-patches] [PATCH v2 1/3] sql: disallow explicit cast of BOOLEAN to number Mergen Imeev via Tarantool-patches
2021-08-04  8:32 ` [Tarantool-patches] [PATCH v2 2/3] sql: disallow explicit cast of VARBINARY " Mergen Imeev via Tarantool-patches
2021-08-04  8:32 ` [Tarantool-patches] [PATCH v2 3/3] sql: fix STRING to BOOLEAN explicit cast Mergen Imeev via Tarantool-patches
2021-08-04 14:16 ` [Tarantool-patches] [PATCH v2 0/3] Fix explicit casts Kirill Yukhin via Tarantool-patches
2021-08-04 15:21   ` Vitaliia Ioffe via Tarantool-patches [this message]
2021-08-05  9:48 ` Kirill Yukhin via Tarantool-patches
  -- strict thread matches above, loose matches on Subject: below --
2021-08-02 17:25 Mergen Imeev via Tarantool-patches
2021-07-30  7:11 Mergen Imeev via Tarantool-patches
2021-07-27 11:31 Mergen Imeev via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1628090519.890717629@f392.i.mail.ru \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=v.ioffe@tarantool.org \
    --subject='Re: [Tarantool-patches]  [PATCH v2 0/3] Fix explicit casts' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox