Tarantool development patches archive
 help / color / mirror / Atom feed
From: Mergen Imeev via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: v.shpilevoy@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v2 0/4] sql: fix description of type mismatch error
Date: Mon,  5 Jul 2021 18:27:45 +0300
Message-ID: <cover.1625498636.git.imeevma@gmail.com> (raw)

After this patch-set value and its type always will be printed in description of
type mismatch error. Currently, in some cases type of value is printed instead
of value.

https://github.com/tarantool/tarantool/issues/6176
https://github.com/tarantool/tarantool/tree/imeevma/gh-6176-fix-type-mismatch-error

Changes in v2:
 - STRING and UUID value now printed in single quotes.
 - Description of type mismatch error now contain both type and value.

Mergen Imeev (4):
  sql: truncate values in type mismatch error
  sql: properly show values in type mismatch error
  sql: use proper type names in error descriptions
  sql: make type mismatch error more informative

 .../type-mistmatch-error-description.md       |    3 +
 src/box/sql/func.c                            |   12 +-
 src/box/sql/mem.c                             |   68 +-
 src/box/sql/mem.h                             |    6 +-
 src/box/sql/vdbe.c                            |   19 +-
 test/sql-tap/autoinc.test.lua                 |    4 +-
 test/sql-tap/cast.test.lua                    |   20 +-
 test/sql-tap/func.test.lua                    |    8 +-
 ...-4766-wrong-cast-from-blob-to-int.test.lua |    9 +-
 .../gh-5913-segfault-on-select-uuid.test.lua  |    4 +-
 test/sql-tap/index1.test.lua                  |    4 +-
 test/sql-tap/numcast.test.lua                 |    4 +-
 test/sql-tap/position.test.lua                |   16 +-
 test/sql-tap/select1.test.lua                 |    6 +-
 test/sql-tap/select5.test.lua                 |    2 +-
 test/sql-tap/sql-errors.test.lua              |  106 +-
 test/sql-tap/tkt-80e031a00f.test.lua          |    8 +-
 test/sql-tap/tkt-9a8b09f8e6.test.lua          |   20 +-
 test/sql-tap/uuid.test.lua                    |  124 +-
 test/sql/boolean.result                       | 1532 ++++++++---------
 test/sql/integer-overflow.result              |    4 +-
 test/sql/persistency.result                   |    2 +-
 test/sql/types.result                         |  176 +-
 23 files changed, 1131 insertions(+), 1026 deletions(-)
 create mode 100644 changelogs/unreleased/type-mistmatch-error-description.md

-- 
2.25.1


             reply	other threads:[~2021-07-05 15:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-05 15:27 Mergen Imeev via Tarantool-patches [this message]
2021-07-05 15:27 ` [Tarantool-patches] [PATCH v2 1/4] sql: truncate values in " Mergen Imeev via Tarantool-patches
2021-07-07 22:09   ` Vladislav Shpilevoy via Tarantool-patches
2021-07-12  8:50     ` Mergen Imeev via Tarantool-patches
2021-07-05 15:27 ` [Tarantool-patches] [PATCH v2 2/4] sql: properly show " Mergen Imeev via Tarantool-patches
2021-07-07 22:09   ` Vladislav Shpilevoy via Tarantool-patches
2021-07-12  8:56     ` Mergen Imeev via Tarantool-patches
2021-07-05 15:27 ` [Tarantool-patches] [PATCH v2 3/4] sql: use proper type names in error descriptions Mergen Imeev via Tarantool-patches
2021-07-05 15:27 ` [Tarantool-patches] [PATCH v2 4/4] sql: make type mismatch error more informative Mergen Imeev via Tarantool-patches
2021-07-07 22:10   ` Vladislav Shpilevoy via Tarantool-patches
2021-07-12  8:58     ` Mergen Imeev via Tarantool-patches
2021-07-12 21:38 ` [Tarantool-patches] [PATCH v2 0/4] sql: fix description of type mismatch error Vladislav Shpilevoy via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1625498636.git.imeevma@gmail.com \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imeevma@tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Tarantool development patches archive

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lists.tarantool.org/tarantool-patches/0 tarantool-patches/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 tarantool-patches tarantool-patches/ https://lists.tarantool.org/tarantool-patches \
		tarantool-patches@dev.tarantool.org.
	public-inbox-index tarantool-patches

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git