From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id AE7A86EC40; Mon, 5 Jul 2021 18:27:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AE7A86EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1625498867; bh=SDPkDdP78Dlo+dNaRRLcyfcpRG83kZoYV6EnjzRgtLA=; h=To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=bdfVSc7tE2dPqZMUwYeprD0oIEpZrjiqqzNodIxuQZmnTFXUyxMVpf4M2oo2FFCqz daQgIioDf4PakskXGcSxw4zTjJPl+Pz8Ps9f5DYKqFywA/e4Qf+CqTTiA9kCQc8Oev DaAuE4oRJrctawM7k08xvLaO2h+RjaoZYsrX0rqE= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 400726EC40 for ; Mon, 5 Jul 2021 18:27:46 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 400726EC40 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1m0QVd-0005S4-JL; Mon, 05 Jul 2021 18:27:46 +0300 To: v.shpilevoy@tarantool.org Cc: tarantool-patches@dev.tarantool.org Date: Mon, 5 Jul 2021 18:27:45 +0300 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD954DFF1DC42D673FB517E8D1A7E34673E94B235AA752823A6182A05F538085040BE69DF8E2A872B63D430CE12274E4A3DB38CB53684873CA08A5A2B2A140D94BC X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE728F774C865CF4B07EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B100969577675F2D8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D877E00F69ACFA0AF6DA05D4612B8D34A0117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC974A882099E279BDA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B66F6A3E018CF4DC80089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: C20DE7B7AB408E4181F030C43753B8186998911F362727C414F749A5E30D975C62E2A2CC9B321AEE214C365E38DB91F0B217B991FCFB1EE89C2B6934AE262D3EE7EAB7254005DCED1C8AEA1E975C27AC1E0A4E2319210D9B64D260DF9561598F01A9E91200F654B0C8396ECC17DE1DB78E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D340EEB18E49183157151446A55C655881DE0B6B273931FAEF68164E924E9C89F9D3CCED1A458DB9C461D7E09C32AA3244CC3DDB15BCFDB4857678E35F01CCB07B224AF4FAF06DA24FD729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojbL9S8ysBdXikNpCAIMCimZPxbQZreVTg X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D2182514D7F8B38ECFF6EDA6C2C84F00E83D72C36FC87018B9F80AB2734326CD2FB559BB5D741EB96352A0ABBE4FDA4210A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: [Tarantool-patches] [PATCH v2 0/4] sql: fix description of type mismatch error X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mergen Imeev via Tarantool-patches Reply-To: imeevma@tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" After this patch-set value and its type always will be printed in description of type mismatch error. Currently, in some cases type of value is printed instead of value. https://github.com/tarantool/tarantool/issues/6176 https://github.com/tarantool/tarantool/tree/imeevma/gh-6176-fix-type-mismatch-error Changes in v2: - STRING and UUID value now printed in single quotes. - Description of type mismatch error now contain both type and value. Mergen Imeev (4): sql: truncate values in type mismatch error sql: properly show values in type mismatch error sql: use proper type names in error descriptions sql: make type mismatch error more informative .../type-mistmatch-error-description.md | 3 + src/box/sql/func.c | 12 +- src/box/sql/mem.c | 68 +- src/box/sql/mem.h | 6 +- src/box/sql/vdbe.c | 19 +- test/sql-tap/autoinc.test.lua | 4 +- test/sql-tap/cast.test.lua | 20 +- test/sql-tap/func.test.lua | 8 +- ...-4766-wrong-cast-from-blob-to-int.test.lua | 9 +- .../gh-5913-segfault-on-select-uuid.test.lua | 4 +- test/sql-tap/index1.test.lua | 4 +- test/sql-tap/numcast.test.lua | 4 +- test/sql-tap/position.test.lua | 16 +- test/sql-tap/select1.test.lua | 6 +- test/sql-tap/select5.test.lua | 2 +- test/sql-tap/sql-errors.test.lua | 106 +- test/sql-tap/tkt-80e031a00f.test.lua | 8 +- test/sql-tap/tkt-9a8b09f8e6.test.lua | 20 +- test/sql-tap/uuid.test.lua | 124 +- test/sql/boolean.result | 1532 ++++++++--------- test/sql/integer-overflow.result | 4 +- test/sql/persistency.result | 2 +- test/sql/types.result | 176 +- 23 files changed, 1131 insertions(+), 1026 deletions(-) create mode 100644 changelogs/unreleased/type-mistmatch-error-description.md -- 2.25.1