From: Serge Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: v.shpilevoy@tarantool.org, gorcunov@gmail.com
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v2 0/2] fix an assertion failure in box.ctl.promote()
Date: Tue, 25 May 2021 13:39:27 +0300 [thread overview]
Message-ID: <cover.1621935783.git.sergepetrenko@tarantool.org> (raw)
https://github.com/tarantool/tarantool/tree/sp/gh-6032-promote-wal-write-v2
https://github.com/tarantool/tarantool/issues/6032
Changes in v2:
- replaced custom waiting for a WAL write with
a single wal_sync() call. This simplified the
patch quite a bit.
- shortened the test. It doesn't test promote()
cancellation now, because wal_sync() isn't
cancellable.
Serge Petrenko (2):
box: refactor in_promote using a guard
box: fix an assertion failure in box.ctl.promote()
src/box/box.cc | 38 ++++++----
.../gh-6032-promote-wal-write.result | 69 +++++++++++++++++++
.../gh-6032-promote-wal-write.test.lua | 28 ++++++++
test/replication/suite.cfg | 1 +
test/replication/suite.ini | 2 +-
5 files changed, 124 insertions(+), 14 deletions(-)
create mode 100644 test/replication/gh-6032-promote-wal-write.result
create mode 100644 test/replication/gh-6032-promote-wal-write.test.lua
--
2.30.1 (Apple Git-130)
next reply other threads:[~2021-05-25 10:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 10:39 Serge Petrenko via Tarantool-patches [this message]
2021-05-25 10:39 ` [Tarantool-patches] [PATCH v2 1/2] box: refactor in_promote using a guard Serge Petrenko via Tarantool-patches
2021-05-26 7:25 ` Cyrill Gorcunov via Tarantool-patches
2021-05-27 10:57 ` Serge Petrenko via Tarantool-patches
2021-05-27 11:02 ` Cyrill Gorcunov via Tarantool-patches
2021-05-25 10:39 ` [Tarantool-patches] [PATCH v2 2/2] box: fix an assertion failure in box.ctl.promote() Serge Petrenko via Tarantool-patches
2021-05-26 6:14 ` Cyrill Gorcunov via Tarantool-patches
2021-05-26 8:25 ` Serge Petrenko via Tarantool-patches
2021-05-26 18:46 ` Vladislav Shpilevoy via Tarantool-patches
2021-05-27 10:53 ` Serge Petrenko via Tarantool-patches
2021-05-27 11:03 ` Cyrill Gorcunov via Tarantool-patches
2021-05-27 19:30 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-01 12:20 ` [Tarantool-patches] [PATCH v2 0/2] " Kirill Yukhin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1621935783.git.sergepetrenko@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 0/2] fix an assertion failure in box.ctl.promote()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox