From: Artem Starshov via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Alexander Turenko <alexander.turenko@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCHv4 0/3] test: -e assert(false) fixup Date: Mon, 18 Jan 2021 15:45:39 +0300 [thread overview] Message-ID: <cover.1610973390.git.artemreyt@tarantool.org> (raw) Changes in v2: - changed commit message name - added 'follows up #4983' - removed collecting details about process due to Linux specific - left only the last commit because the previous was pushed to master and the first one is empty after the review - added comment describing the reason of using timeout module in presence of built-in 'popen' module Changes in v3: - split one commit into two: first - increase timeout, second - move helper functions to separated module Changes in v4: - split two commits into 3: first - increase timeout, second - add module process_timeout, third - modify -e assert(false) test using process_timeout. Creating module `process_timeout` in separate commit is convenient for working under other tests using this module while this patch isn't pushed on master. Artem Starshov (3): test: change timeout in -e assert(false) test test: add separated module for proccess operations with timeout test: change -e assert(false) test using process_timeout module .../gh-4983-tnt-e-assert-false-hangs.test.lua | 70 ++++--------------- test/app-tap/lua/process_timeout.lua | 59 ++++++++++++++++ test/app-tap/suite.ini | 2 +- 3 files changed, 74 insertions(+), 57 deletions(-) create mode 100644 test/app-tap/lua/process_timeout.lua -- 2.28.0
next reply other threads:[~2021-01-18 12:45 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-18 12:45 Artem Starshov via Tarantool-patches [this message] 2021-01-18 12:45 ` [Tarantool-patches] [PATCHv4 1/3] test: change timeout in -e assert(false) test Artem Starshov via Tarantool-patches 2021-01-21 16:20 ` Sergey Bronnikov via Tarantool-patches 2021-01-26 10:26 ` Artem via Tarantool-patches 2021-01-18 12:45 ` [Tarantool-patches] [PATCHv4 2/3] test: add separated module for proccess operations with timeout Artem Starshov via Tarantool-patches 2021-01-18 12:45 ` [Tarantool-patches] [PATCHv4 3/3] test: change -e assert(false) test using process_timeout module Artem Starshov via Tarantool-patches 2021-01-21 16:23 ` Sergey Bronnikov via Tarantool-patches 2021-01-26 10:25 ` Artem via Tarantool-patches 2021-01-18 12:47 ` [Tarantool-patches] [PATCHv4 0/3] test: -e assert(false) fixup Artem via Tarantool-patches 2021-01-21 16:23 ` Sergey Bronnikov via Tarantool-patches 2021-01-27 13:19 ` Kirill Yukhin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1610973390.git.artemreyt@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=alexander.turenko@tarantool.org \ --cc=artemreyt@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCHv4 0/3] test: -e assert(false) fixup' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox