From: Artem Starshov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCHv3 0/2] test: -e assert(false) test fixup
Date: Thu, 14 Jan 2021 12:45:38 +0300 [thread overview]
Message-ID: <cover.1610615519.git.artemreyt@tarantool.org> (raw)
Changes in v2:
- changed commit message name
- added 'follows up #4983'
- removed collecting details about process due to Linux specific
- left only the last commit because the previous was pushed to master
and the first one is empty after the review
- added comment describing the reason of using timeout module in
presence of built-in 'popen' module
Changes in v3:
- split one commit into two: first - increase timeout, second - move
helper functions to separated module
Branch: https://github.com/tarantool/tarantool/tree/artemreyt/gh-4983-fix-test
Artem Starshov (2):
test: increase timeout in -e assert(false) test
test: move helper functions to separated module in -e assert(false)
test
.../gh-4983-tnt-e-assert-false-hangs.test.lua | 72 ++++---------------
test/app-tap/lua/process_timeout.lua | 57 +++++++++++++++
test/app-tap/suite.ini | 2 +-
3 files changed, 73 insertions(+), 58 deletions(-)
create mode 100644 test/app-tap/lua/process_timeout.lua
--
2.28.0
next reply other threads:[~2021-01-14 9:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 9:45 Artem Starshov via Tarantool-patches [this message]
2021-01-14 9:45 ` [Tarantool-patches] [PATCHv3 1/2] test: increase timeout in -e assert(false) test Artem Starshov via Tarantool-patches
2021-01-15 9:13 ` Leonid Vasiliev via Tarantool-patches
2021-01-15 9:17 ` Leonid Vasiliev via Tarantool-patches
2021-01-14 9:45 ` [Tarantool-patches] [PATCHv3 2/2] test: move helper functions to separated module " Artem Starshov via Tarantool-patches
2021-01-15 9:37 ` Leonid Vasiliev via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1610615519.git.artemreyt@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=artemreyt@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCHv3 0/2] test: -e assert(false) test fixup' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox