From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
To: Aleksandr Lyapunov <alyapunov@tarantool.org>,
Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v2 0/2] test: flaky hang vinyl/ddl.test.lua test
Date: Fri, 4 Dec 2020 11:05:38 +0300 [thread overview]
Message-ID: <cover.1607036572.git.avtikhon@tarantool.org> (raw)
Patchset consists of 2 commits:
1. Revert "Fix flaky test engine/ddl"
Found that the previous fix of the engine/ddl.test.lua test committed
with:
5f96ee5907672bd32dd7fe8dad144ac3d328187f ('Fix flaky test engine/ddl')
did not fix the issue #4353 in real and it was reverted.
2. test: flaky hang vinyl/ddl.test.lua test
Found hanging test vinyl/ddl.test.lua on:
[159] inspector:wait_cond(function() return box.space.test.index.pk:count() == box.space.test.index.tk:count() end)
[159] ---
[159] - true
[159] ...
[159] -box.snapshot()
[159] ----
[159] -- ok
[159] -...
The real issue happend before it when test failed on:
[091] --- engine/ddl.result Thu May 14 16:12:09 2020
[091] +++ engine/ddl.reject Fri May 15 04:15:07 2020
[091] @@ -2558,7 +2558,7 @@
[091] ...
[091] inspector:wait_cond(function() return box.space.test.index.pk:count() == box.space.test.index.sk:count() end)
[091] ---
[091] -- true
[091] +- false
[091] ...
Our tests have structure when different standalone subtests exists
in the test files. To be able to check all of them this hang must
be neutralized to give the next standalone subtest ability to pass.
To avoid of this hang decided to disable box.snapshot check if the
previous check of the current subtest failed.
Needed for #4353
Alexander V. Tikhonov (2):
Revert "Fix flaky test engine/ddl"
test: flaky hang vinyl/ddl.test.lua test
---
Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4353-hang-ddl
Issue: https://github.com/tarantool/tarantool/issues/4353
test/engine/ddl.result | 91 ++++++++++++++++++++++++++--------------
test/engine/ddl.test.lua | 76 ++++++++++++++++++++++++++-------
test/engine/suite.ini | 2 +-
3 files changed, 122 insertions(+), 47 deletions(-)
--
2.24.1 (Apple Git-126)
next reply other threads:[~2020-12-04 8:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 8:05 Alexander V. Tikhonov [this message]
2020-12-04 8:05 ` [Tarantool-patches] [PATCH v2 1/2] Revert "Fix flaky test engine/ddl" Alexander V. Tikhonov
2020-12-04 8:05 ` [Tarantool-patches] [PATCH v2 2/2] test: flaky hang vinyl/ddl.test.lua test Alexander V. Tikhonov
2020-12-04 8:19 ` Aleksandr Lyapunov
2020-12-04 8:34 ` Aleksandr Lyapunov
2020-12-04 8:34 ` [Tarantool-patches] [PATCH v2 0/2] " Aleksandr Lyapunov
2020-12-04 9:35 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1607036572.git.avtikhon@tarantool.org \
--to=avtikhon@tarantool.org \
--cc=alyapunov@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 0/2] test: flaky hang vinyl/ddl.test.lua test' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox