Tarantool development patches archive
 help / color / mirror / Atom feed
From: olegrok@tarantool.org
To: v.shpilevoy@tarantool.org, lvasiliev@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v2 0/2] Make uuid values comparable
Date: Wed, 18 Nov 2020 10:56:19 +0300	[thread overview]
Message-ID: <cover.1605685304.git.babinoleg@mail.ru> (raw)

From: Oleg Babin <babinoleg@mail.ru>

This patchset makes uuid values comparable.

The first one allows
to compare only uuid values. It's just define lt and le methods
for uuid values.

The second one allows to compare uuid values with string
representations of uuid. Just note that this patch breaks backward
compatibility - before all attempts to check equality with
non-uuid values returned false. Currently it's not so.
It we want do that this patch could be omitted.

Issue: https://github.com/tarantool/tarantool/issues/5511
Branch: https://github.com/tarantool/tarantool/tree/olegrok/5511-uuid-cmp-v2

Changes with v1:
  - Use static_alloc when string is converted to uuid to compare
  - Style fixes
  - Extend "eq" for comparison with string
  - Split patch in two parts

Oleg Babin (2):
  uuid: support comparison of uuid values in Lua
  uuid: support uuid comparison with strings

 src/exports.h          |   1 +
 src/lua/uuid.lua       |  52 ++++++++++++++-
 test/app/uuid.result   | 148 +++++++++++++++++++++++++++++++++++++++++
 test/app/uuid.test.lua |  56 ++++++++++++++++
 4 files changed, 255 insertions(+), 2 deletions(-)

-- 
2.29.0

             reply	other threads:[~2020-11-18  7:56 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-18  7:56 olegrok [this message]
2020-11-18  7:56 ` [Tarantool-patches] [PATCH v2 1/2] uuid: support comparison of uuid values in Lua olegrok
2020-11-21 15:17   ` Vladislav Shpilevoy
2020-11-21 19:07     ` Oleg Babin
2020-11-23 21:58       ` Vladislav Shpilevoy
2020-11-24  5:57         ` Oleg Babin
2020-11-24 13:06           ` Igor Munkin
2020-11-27 15:17         ` Oleg Babin
2020-11-24 15:20   ` Igor Munkin
2020-11-24 19:23     ` Oleg Babin
2020-11-18  7:56 ` [Tarantool-patches] [PATCH v2 2/2] uuid: support uuid comparison with strings olegrok
2020-11-21 15:17   ` Vladislav Shpilevoy
2020-11-21 19:07     ` Oleg Babin
2020-11-24 15:20   ` Igor Munkin
2020-11-24 19:23     ` Oleg Babin
2020-11-18  8:02 ` [Tarantool-patches] [PATCH v2 0/2] Make uuid values comparable Oleg Babin
2020-11-27 22:39 ` Vladislav Shpilevoy
2020-11-27 22:40 ` Vladislav Shpilevoy
2020-12-04  8:13   ` Oleg Babin
2020-12-07 23:04     ` Alexander V. Tikhonov
2020-12-07 23:24 ` Vladislav Shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1605685304.git.babinoleg@mail.ru \
    --to=olegrok@tarantool.org \
    --cc=lvasiliev@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v2 0/2] Make uuid values comparable' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox