Tarantool development patches archive
 help / color / mirror / Atom feed
From: imeevma@tarantool.org
To: korablev@tarantool.org, tsafin@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v5 0/6] sql; remove implicit cast for comparison
Date: Fri, 21 Aug 2020 12:19:47 +0300	[thread overview]
Message-ID: <cover.1598000242.git.imeevma@gmail.com> (raw)

This patch-set removes implicit cast from STRING to NUMBER and vice versa for
comparison.

https://github.com/tarantool/tarantool/issues/4230
https://github.com/tarantool/tarantool/tree/imeevma/gh-4230-remove-implicit-cast-for-comparison

@ChangeLog
 - Implicit cast from STRING to number and vice versa for comparison removed (gh-4230).

Changes in v5:
 - Patches were moved in a new patch-set.
 - Patch-set was simplified since implicit cast for assignment was removed.

Mergen Imeev (6):
  sql: remove unused DOUBLE to INTEGER conversion
  sql: add implicit cast between numbers in OP_Seek*
  sql: change comparison between numbers using index
  sql: remove implicit cast from comparison opcodes
  sql: fix implicit cast in opcode MustBeInt
  sql: remove implicit cast from MakeRecord opcode

 src/box/sql/analyze.c                 |   6 +-
 src/box/sql/delete.c                  |  15 +-
 src/box/sql/expr.c                    |  17 +-
 src/box/sql/fk_constraint.c           |  12 +-
 src/box/sql/select.c                  |  26 +-
 src/box/sql/sqlInt.h                  |   2 +
 src/box/sql/update.c                  |  23 +-
 src/box/sql/vdbe.c                    | 536 ++++++++++++++++++--------
 src/box/sql/wherecode.c               | 103 +----
 test/sql-tap/identifier_case.test.lua |   6 +-
 test/sql-tap/in1.test.lua             |   4 +-
 test/sql-tap/in3.test.lua             |  26 +-
 test/sql-tap/in4.test.lua             |   4 +-
 test/sql-tap/insert3.test.lua         |   2 +-
 test/sql-tap/join.test.lua            |   8 +-
 test/sql-tap/misc1.test.lua           |  32 +-
 test/sql-tap/select1.test.lua         |   4 +-
 test/sql-tap/select7.test.lua         |   2 +-
 test/sql-tap/subquery.test.lua        |   4 +-
 test/sql-tap/tkt-9a8b09f8e6.test.lua  | 508 ------------------------
 test/sql-tap/tkt3493.test.lua         |  40 +-
 test/sql-tap/transitive1.test.lua     |  12 +-
 test/sql-tap/where2.test.lua          | 183 +--------
 test/sql-tap/where5.test.lua          |  12 +-
 test/sql/boolean.result               |  76 +---
 test/sql/types.result                 | 286 +++++++++++++-
 test/sql/types.test.lua               |  63 +++
 27 files changed, 875 insertions(+), 1137 deletions(-)
 delete mode 100755 test/sql-tap/tkt-9a8b09f8e6.test.lua

-- 
2.25.1

             reply	other threads:[~2020-08-21  9:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-21  9:19 imeevma [this message]
2020-08-21  9:19 ` [Tarantool-patches] [PATCH v5 1/6] sql: remove unused DOUBLE to INTEGER conversion imeevma
2020-09-17 14:48   ` Nikita Pettik
2020-09-28 15:50     ` Mergen Imeev
2020-08-21  9:19 ` [Tarantool-patches] [PATCH v5 2/6] sql: add implicit cast between numbers in OP_Seek* imeevma
2020-09-17 15:34   ` Nikita Pettik
2020-09-28 15:55     ` Mergen Imeev
2020-08-21  9:19 ` [Tarantool-patches] [PATCH v5 3/6] sql: change comparison between numbers using index imeevma
2020-09-18  8:08   ` Nikita Pettik
2020-09-28 16:10     ` Mergen Imeev
2020-08-21  9:19 ` [Tarantool-patches] [PATCH v5 4/6] sql: remove implicit cast from comparison opcodes imeevma
2020-08-21  9:19 ` [Tarantool-patches] [PATCH v5 5/6] sql: fix implicit cast in opcode MustBeInt imeevma
2020-08-21  9:19 ` [Tarantool-patches] [PATCH v5 6/6] sql: remove implicit cast from MakeRecord opcode imeevma
2020-09-18 12:28   ` Nikita Pettik
2020-09-28 16:19     ` Mergen Imeev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1598000242.git.imeevma@gmail.com \
    --to=imeevma@tarantool.org \
    --cc=korablev@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=tsafin@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v5 0/6] sql; remove implicit cast for comparison' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox