From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3A259430407 for ; Fri, 21 Aug 2020 12:19:49 +0300 (MSK) From: imeevma@tarantool.org Date: Fri, 21 Aug 2020 12:19:47 +0300 Message-Id: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH v5 0/6] sql; remove implicit cast for comparison List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: korablev@tarantool.org, tsafin@tarantool.org Cc: tarantool-patches@dev.tarantool.org This patch-set removes implicit cast from STRING to NUMBER and vice versa for comparison. https://github.com/tarantool/tarantool/issues/4230 https://github.com/tarantool/tarantool/tree/imeevma/gh-4230-remove-implicit-cast-for-comparison @ChangeLog - Implicit cast from STRING to number and vice versa for comparison removed (gh-4230). Changes in v5: - Patches were moved in a new patch-set. - Patch-set was simplified since implicit cast for assignment was removed. Mergen Imeev (6): sql: remove unused DOUBLE to INTEGER conversion sql: add implicit cast between numbers in OP_Seek* sql: change comparison between numbers using index sql: remove implicit cast from comparison opcodes sql: fix implicit cast in opcode MustBeInt sql: remove implicit cast from MakeRecord opcode src/box/sql/analyze.c | 6 +- src/box/sql/delete.c | 15 +- src/box/sql/expr.c | 17 +- src/box/sql/fk_constraint.c | 12 +- src/box/sql/select.c | 26 +- src/box/sql/sqlInt.h | 2 + src/box/sql/update.c | 23 +- src/box/sql/vdbe.c | 536 ++++++++++++++++++-------- src/box/sql/wherecode.c | 103 +---- test/sql-tap/identifier_case.test.lua | 6 +- test/sql-tap/in1.test.lua | 4 +- test/sql-tap/in3.test.lua | 26 +- test/sql-tap/in4.test.lua | 4 +- test/sql-tap/insert3.test.lua | 2 +- test/sql-tap/join.test.lua | 8 +- test/sql-tap/misc1.test.lua | 32 +- test/sql-tap/select1.test.lua | 4 +- test/sql-tap/select7.test.lua | 2 +- test/sql-tap/subquery.test.lua | 4 +- test/sql-tap/tkt-9a8b09f8e6.test.lua | 508 ------------------------ test/sql-tap/tkt3493.test.lua | 40 +- test/sql-tap/transitive1.test.lua | 12 +- test/sql-tap/where2.test.lua | 183 +-------- test/sql-tap/where5.test.lua | 12 +- test/sql/boolean.result | 76 +--- test/sql/types.result | 286 +++++++++++++- test/sql/types.test.lua | 63 +++ 27 files changed, 875 insertions(+), 1137 deletions(-) delete mode 100755 test/sql-tap/tkt-9a8b09f8e6.test.lua -- 2.25.1