From: imeevma@tarantool.org To: v.shpilevoy@tarantool.org Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH v1 0/7] sql: properly check arguments types of built-in functions Date: Wed, 12 Aug 2020 18:15:42 +0300 [thread overview] Message-ID: <cover.1597244875.git.imeevma@gmail.com> (raw) This patch-set makes SQL to use the ApplyType opcode to validate the argument types of built-in functions. https://github.com/tarantool/tarantool/issues/4159 https://github.com/tarantool/tarantool/tree/imeevma/gh-4159-rework-sql-builtins @ChangeLog - Built-in function argument types are now properly checked (gh-4159). Mergen Imeev (7): box: add has_vararg option for functions sql: do not return UNSIGNED in built-in functions sql: move built-in function definitions in _func box: add param_list to 'struct func' sql: check built-in functions argument types sql: VARBINARY and STRING in built-in functions sql: refactor sql/func.c src/box/alter.cc | 12 +- src/box/bootstrap.snap | Bin 5976 -> 6291 bytes src/box/func.c | 1 + src/box/func_def.c | 5 + src/box/func_def.h | 8 + src/box/lua/call.c | 2 + src/box/lua/upgrade.lua | 143 +++ src/box/sql/expr.c | 4 + src/box/sql/func.c | 894 +++---------------- src/box/sql/resolve.c | 2 +- src/box/sql/select.c | 26 + src/box/sql/sqlInt.h | 14 + src/box/sql/vdbeapi.c | 2 +- test/box-py/bootstrap.result | 2 +- test/sql-tap/cse.test.lua | 4 +- test/sql-tap/func.test.lua | 36 +- test/sql-tap/orderby1.test.lua | 2 +- test/sql-tap/position.test.lua | 6 +- test/sql/boolean.result | 32 +- test/sql/checks.result | 8 - test/sql/checks.test.lua | 2 - test/sql/types.result | 1489 +++++++++++++++++++++++++++++++- test/sql/types.test.lua | 250 ++++++ 23 files changed, 2092 insertions(+), 852 deletions(-) -- 2.25.1
next reply other threads:[~2020-08-12 15:15 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-12 15:15 imeevma [this message] 2020-08-12 15:15 ` [Tarantool-patches] [PATCH v1 1/7] box: add has_vararg option for functions imeevma 2020-08-12 15:15 ` [Tarantool-patches] [PATCH v1 2/7] sql: do not return UNSIGNED in built-in functions imeevma 2020-08-12 15:15 ` [Tarantool-patches] [PATCH v1 3/7] sql: move built-in function definitions in _func imeevma 2020-08-12 15:15 ` [Tarantool-patches] [PATCH v1 4/7] box: add param_list to 'struct func' imeevma 2020-08-12 15:15 ` [Tarantool-patches] [PATCH v1 5/7] sql: check built-in functions argument types imeevma 2020-08-12 15:15 ` [Tarantool-patches] [PATCH v1 6/7] sql: VARBINARY and STRING in built-in functions imeevma 2020-08-12 15:15 ` [Tarantool-patches] [PATCH v1 7/7] sql: refactor sql/func.c imeevma
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1597244875.git.imeevma@gmail.com \ --to=imeevma@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v1 0/7] sql: properly check arguments types of built-in functions' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox