Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@dev.tarantool.org, gorcunov@gmail.com
Subject: [Tarantool-patches] [PATCH 0/2] Make txn_commit() simpler
Date: Wed, 22 Jul 2020 00:42:42 +0200	[thread overview]
Message-ID: <cover.1595371239.git.v.shpilevoy@tarantool.org> (raw)

The patch makes so journal_write() always ends with the
transaction completed, with TXN_IS_DONE flag installed. That
allows to remove 1 'if' from hot txn_commit() function, and make
journal API more straightforward.

This change also motivated rework of how limbo commits
transactions.

Branch: http://github.com/tarantool/tarantool/tree/gerold103/txn_commit-opt

Vladislav Shpilevoy (2):
  txn_limbo: single function to confirm transactions
  txn: remove TXN_IS_DONE check from txn_commit()

 src/box/box.cc      | 36 +++++++++++++-----
 src/box/journal.c   | 45 +----------------------
 src/box/journal.h   | 11 ------
 src/box/txn.c       |  6 +--
 src/box/txn_limbo.c | 89 ++++++++++++++++++---------------------------
 src/box/wal.c       |  2 +-
 test/unit/suite.ini |  1 +
 7 files changed, 68 insertions(+), 122 deletions(-)

-- 
2.21.1 (Apple Git-122.3)

             reply	other threads:[~2020-07-21 22:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-21 22:42 Vladislav Shpilevoy [this message]
2020-07-21 22:42 ` [Tarantool-patches] [PATCH 1/2] txn_limbo: single function to confirm transactions Vladislav Shpilevoy
2020-07-22 15:19   ` Leonid Vasiliev
2020-07-21 22:42 ` [Tarantool-patches] [PATCH 2/2] txn: remove TXN_IS_DONE check from txn_commit() Vladislav Shpilevoy
2020-07-22 15:28   ` Leonid Vasiliev
2020-07-22  8:40 ` [Tarantool-patches] [PATCH 0/2] Make txn_commit() simpler Cyrill Gorcunov
2020-07-22 23:14 ` Vladislav Shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1595371239.git.v.shpilevoy@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=gorcunov@gmail.com \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 0/2] Make txn_commit() simpler' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox