Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@dev.tarantool.org, gorcunov@gmail.com
Subject: [Tarantool-patches] [PATCH 0/2] Qsync crash on WAL write fail
Date: Mon, 20 Jul 2020 22:43:04 +0200	[thread overview]
Message-ID: <cover.1595277631.git.v.shpilevoy@tarantool.org> (raw)

The patchset fixes the crash when a synchronous transaction
couldn't to local master's WAL, getting an error from inside of
the WAL thread.

Note, the test is added to the existing file instead of creating
a new one intentionally. It is not so cheap to create new instance
for each new test, and also would complicate running all qsync
tests by prefix like this: `python test-run.py replication/qsync`.
Besides, the test is simple. Copy-pastable to console not counting
test_run:switch() calls.

Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-5146-qsync-crash
Issue: https://github.com/tarantool/tarantool/issues/5146

Vladislav Shpilevoy (2):
  txn: single failure point for WAL and TX commit errors
  txn: single failure point for WAL and TX async commit errors

 src/box/txn.c                          | 88 +++++++++++---------------
 test/replication/qsync_errinj.result   | 69 ++++++++++++++++++++
 test/replication/qsync_errinj.test.lua | 28 ++++++++
 3 files changed, 134 insertions(+), 51 deletions(-)

-- 
2.21.1 (Apple Git-122.3)

             reply	other threads:[~2020-07-20 20:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-20 20:43 Vladislav Shpilevoy [this message]
2020-07-20 20:43 ` [Tarantool-patches] [PATCH 1/2] txn: single failure point for WAL and TX commit errors Vladislav Shpilevoy
2020-07-21  8:42   ` Cyrill Gorcunov
2020-07-20 20:43 ` [Tarantool-patches] [PATCH 2/2] txn: single failure point for WAL and TX async " Vladislav Shpilevoy
2020-07-21  8:43   ` Cyrill Gorcunov
2020-07-20 20:44 ` [Tarantool-patches] [PATCH 0/2] Qsync crash on WAL write fail Vladislav Shpilevoy
2020-07-21 20:25 ` Vladislav Shpilevoy
2020-07-22 10:41   ` Kirill Yukhin
2020-07-22 22:27     ` Vladislav Shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1595277631.git.v.shpilevoy@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=gorcunov@gmail.com \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 0/2] Qsync crash on WAL write fail' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox