From: "Alexander V. Tikhonov" <avtikhon@tarantool.org> To: Kirill Yukhin <kyukhin@tarantool.org>, Alexander Turenko <alexander.turenko@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH v2 0/3] gitlab-ci: add openSuSE packages build jobs Date: Tue, 7 Jul 2020 16:20:55 +0300 [thread overview] Message-ID: <cover.1594126705.git.avtikhon@tarantool.org> (raw) gitlab-ci: add openSuSE packages build jobs Implemented openSuSE packages build with testing for images: opensuse-leap:15.[0-2] Added %{sle_version} checks in Tarantool spec file according to https://en.opensuse.org/openSUSE:Packaging_for_Leap#RPM_Distro_Version_Macros Found that openSuSE adding linker flag '--no-undefined' which produces the fails on building tests. Decided to block this flag due to dynamic libraries will be loaded from tarantool executable and will use symbols from it. So it is completely okay to have unresolved symbols at build time. Added opensuse-leap of 15.1 and 15.2 versions to Gitlab-CI packages building/deploing jobs. Found that test fails on its subtest checking: "gh-2872 bootstrap is aborted if vinyl_dir contains vylog files left from previous runs" Debugging src/box/xlog.c found that all checks were correct, but at function: src/box/vy_log.c:vy_log_bootstrap() the check on of the errno on ENOENT blocked the negative return from function: src/box/xlog.c:xdir_scan() Found that errno was already set to ENOENT before the xdir_scan() call. To fix the issue the errno must be clean before the call to xdir_scan, because we are interesting in it only from this function. The same issue fixed at function: src/box/vy_log.c:vy_log_begin_recovery() Found that opensuse adding linker flag '--no-undefined' which produces the fails on building tests. Decided to block this flag due to dynamic libraries will be loaded from tarantool executable and will use symbols from it. So it is completely okay to have unresolved symbols at build time. Closes #4562 Closes #4594 Needed for #4562 Alexander V. Tikhonov (5): Bump luajit repository Fix test box-tap/cfg.test.lua on openSuSE gitlab-ci: add openSuSE packages build jobs TMP: check packpack SuSE TMP: Check --- Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4562-suse-pack-full-ci Issue: https://github.com/tarantool/tarantool/issues/4562 Issue: https://github.com/tarantool/tarantool/issues/4594 .gitlab-ci.yml | 24 ++++++++++++++++++++++++ .gitlab.mk | 9 +++++---- rpm/tarantool.spec | 16 +++++++++++----- src/box/vy_log.c | 2 ++ test/app-tap/CMakeLists.txt | 4 ++++ test/app/CMakeLists.txt | 4 ++++ test/box-tap/cfg.skipcond | 10 ++++++++++ test/box/CMakeLists.txt | 4 ++++ third_party/luajit | 2 +- tools/update_repo.sh | 6 ++++-- 10 files changed, 69 insertions(+), 12 deletions(-) -- 2.17.1
next reply other threads:[~2020-07-07 13:21 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-07 13:20 Alexander V. Tikhonov [this message] 2020-07-07 13:20 ` [Tarantool-patches] [PATCH v2 1/3] Bump luajit repository Alexander V. Tikhonov 2020-07-07 13:20 ` [Tarantool-patches] [PATCH v2 2/3] Fix test box-tap/cfg.test.lua on openSuSE Alexander V. Tikhonov 2020-08-14 2:44 ` Alexander Turenko 2020-08-14 12:42 ` Alexander V. Tikhonov 2020-07-07 13:20 ` [Tarantool-patches] [PATCH v2 3/3] gitlab-ci: add openSuSE packages build jobs Alexander V. Tikhonov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1594126705.git.avtikhon@tarantool.org \ --to=avtikhon@tarantool.org \ --cc=alexander.turenko@tarantool.org \ --cc=kyukhin@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v2 0/3] gitlab-ci: add openSuSE packages build jobs' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox