From: imeevma@tarantool.org
To: korablev@tarantool.org, tsafin@tarantool.org,
tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v3 0/8] Remove implicit cast
Date: Thu, 25 Jun 2020 18:17:18 +0300 [thread overview]
Message-ID: <cover.1593096639.git.imeevma@gmail.com> (raw)
This patch-set removes implicit cast between string and numbers
for assignment and for comparison.
https://github.com/tarantool/tarantool/issues/3809
https://github.com/tarantool/tarantool/issues/4230
https://github.com/tarantool/tarantool/tree/imeevma/gh-3809-disallow-imlicit-cast-from-string-to-nums
@ChangeLog
- [Breaking change] Removed implicit cast from string to numbers
and vice versa for assignment and comparison.
v2:
- Added a commit that changes the type mismatch error
description.
v3:
- Introduction of mem_set_double() was moved to another commit.
- Implicit cast rules for assigning were changed.
Mergen Imeev (8):
sql: introduce mem_set_double()
sql: change implicit cast for assignment
sql: remove mem_apply_type() from OP_MakeRecord
sql: replace ApplyType by CheckType for IN operator
sql: remove mem_apply_type() from OP_MustBeInt
sql: remove implicit cast for comparison
sql: remove unused functions
sql: show value and its type in type mismatch error
src/box/sql/analyze.c | 7 +-
src/box/sql/delete.c | 8 +-
src/box/sql/expr.c | 53 +-
src/box/sql/fk_constraint.c | 9 +-
src/box/sql/func.c | 8 +-
src/box/sql/insert.c | 16 +-
src/box/sql/select.c | 25 +-
src/box/sql/sqlInt.h | 34 +-
src/box/sql/update.c | 14 +-
src/box/sql/vdbe.c | 322 ++--
src/box/sql/vdbeInt.h | 5 +-
src/box/sql/vdbeapi.c | 31 +-
src/box/sql/vdbemem.c | 38 +-
src/box/sql/wherecode.c | 211 +--
test/sql-tap/autoinc.test.lua | 6 +-
test/sql-tap/cast.test.lua | 16 +-
test/sql-tap/default.test.lua | 6 +-
test/sql-tap/e_select1.test.lua | 27 +-
.../gh-3809-implicit-cast-assignment.test.lua | 653 ++++++++
.../gh-4230-del-impl-cast-str-to-num.test.lua | 281 ++++
...-4766-wrong-cast-from-blob-to-int.test.lua | 9 +-
test/sql-tap/identifier_case.test.lua | 6 +-
test/sql-tap/in1.test.lua | 4 +-
test/sql-tap/in3.test.lua | 18 +-
test/sql-tap/in4.test.lua | 100 +-
test/sql-tap/index1.test.lua | 28 +-
test/sql-tap/insert3.test.lua | 12 +-
test/sql-tap/intpkey.test.lua | 133 +-
test/sql-tap/join.test.lua | 8 +-
test/sql-tap/limit.test.lua | 2 +-
test/sql-tap/minmax2.test.lua | 6 +-
test/sql-tap/misc1.test.lua | 66 +-
test/sql-tap/numcast.test.lua | 8 +-
test/sql-tap/select1.test.lua | 18 +-
test/sql-tap/select4.test.lua | 12 +-
test/sql-tap/select5.test.lua | 2 +-
test/sql-tap/select7.test.lua | 4 +-
test/sql-tap/sort.test.lua | 8 +-
test/sql-tap/subquery.test.lua | 73 +-
test/sql-tap/tkt-3998683a16.test.lua | 26 +-
test/sql-tap/tkt-54844eea3f.test.lua | 8 +-
test/sql-tap/tkt-7bbfb7d442.test.lua | 4 +-
test/sql-tap/tkt-80e031a00f.test.lua | 4 +-
test/sql-tap/tkt-9a8b09f8e6.test.lua | 528 ------
test/sql-tap/tkt-f973c7ac31.test.lua | 18 +-
test/sql-tap/tkt-fc7bd6358f.test.lua | 111 --
test/sql-tap/tkt1444.test.lua | 4 +-
test/sql-tap/tkt3493.test.lua | 46 +-
test/sql-tap/tkt3841.test.lua | 12 +-
test/sql-tap/transitive1.test.lua | 16 +-
test/sql-tap/triggerA.test.lua | 4 +-
test/sql-tap/unique.test.lua | 8 +-
test/sql-tap/view.test.lua | 2 +-
test/sql-tap/where2.test.lua | 183 +-
test/sql-tap/where5.test.lua | 22 +-
test/sql-tap/whereB.test.lua | 908 ----------
test/sql-tap/whereC.test.lua | 8 +-
test/sql/boolean.result | 1484 ++++++++---------
test/sql/integer-overflow.result | 4 +-
test/sql/persistency.result | 2 +-
test/sql/types.result | 67 +-
test/sql/types.test.lua | 1 -
62 files changed, 2231 insertions(+), 3526 deletions(-)
create mode 100755 test/sql-tap/gh-3809-implicit-cast-assignment.test.lua
create mode 100755 test/sql-tap/gh-4230-del-impl-cast-str-to-num.test.lua
delete mode 100755 test/sql-tap/tkt-9a8b09f8e6.test.lua
delete mode 100755 test/sql-tap/tkt-fc7bd6358f.test.lua
delete mode 100755 test/sql-tap/whereB.test.lua
--
2.25.1
next reply other threads:[~2020-06-25 15:17 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 15:17 imeevma [this message]
2020-06-25 15:17 ` [Tarantool-patches] [PATCH v3 1/8] sql: introduce mem_set_double() imeevma
2020-06-28 13:31 ` Nikita Pettik
2020-07-06 14:02 ` Nikita Pettik
2020-06-25 15:17 ` [Tarantool-patches] [PATCH v3 2/8] sql: change implicit cast for assignment imeevma
2020-06-30 11:50 ` Nikita Pettik
2020-07-05 14:26 ` Mergen Imeev
2020-07-06 21:27 ` Nikita Pettik
2020-07-07 9:29 ` Mergen Imeev
2020-07-07 15:35 ` Nikita Pettik
2020-07-10 10:49 ` Nikita Pettik
2020-06-25 15:17 ` [Tarantool-patches] [PATCH v3 3/8] sql: remove mem_apply_type() from OP_MakeRecord imeevma
2020-06-25 15:17 ` [Tarantool-patches] [PATCH v3 4/8] sql: replace ApplyType by CheckType for IN operator imeevma
2020-06-29 12:56 ` Nikita Pettik
2020-07-05 14:28 ` Mergen Imeev
2020-07-06 22:06 ` Nikita Pettik
2020-07-07 11:26 ` Mergen Imeev
2020-07-07 16:29 ` Nikita Pettik
2020-06-25 15:17 ` [Tarantool-patches] [PATCH v3 5/8] sql: remove mem_apply_type() from OP_MustBeInt imeevma
2020-06-29 13:29 ` Nikita Pettik
2020-07-05 14:29 ` Mergen Imeev
2020-06-25 15:17 ` [Tarantool-patches] [PATCH v3 6/8] sql: remove implicit cast for comparison imeevma
2020-06-29 23:51 ` Nikita Pettik
2020-07-05 14:47 ` Mergen Imeev
2020-07-06 23:11 ` Nikita Pettik
2020-06-25 15:17 ` [Tarantool-patches] [PATCH v3 7/8] sql: remove unused functions imeevma
2020-06-29 23:52 ` Nikita Pettik
2020-07-05 14:50 ` Mergen Imeev
2020-06-25 15:17 ` [Tarantool-patches] [PATCH v3 8/8] sql: show value and its type in type mismatch error imeevma
2020-06-30 0:22 ` Nikita Pettik
2020-07-05 15:03 ` Mergen Imeev
2020-07-06 21:44 ` Nikita Pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1593096639.git.imeevma@gmail.com \
--to=imeevma@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tsafin@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v3 0/8] Remove implicit cast' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox