From: Mergen Imeev <imeevma@tarantool.org>
To: v.shpilevoy@tarantool.org, tsafin@tarantool.org,
tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH 0/6] Remove implicit cast
Date: Thu, 28 May 2020 17:17:25 +0300 [thread overview]
Message-ID: <cover.1590671266.git.imeevma@gmail.com> (raw)
This patch-set removes implicit cast between string and numbers
for assignment and for comparison.
https://github.com/tarantool/tarantool/issues/3809
https://github.com/tarantool/tarantool/issues/4230
https://github.com/tarantool/tarantool/tree/imeevma/gh-3809-disallow-imlicit-cast-from-string-to-nums
Mergen Imeev (6):
sql: remove implicit cast for assignment
sql: remove mem_apply_type() from OP_MakeRecord
sql: replace ApplyType by CheckType for IN operator
sql: remove mem_apply_type() from OP_MustBeInt
sql: remove implicit cast from string for comparison
sql: remove OP_ApplyType
src/box/sql/analyze.c | 7 +-
src/box/sql/delete.c | 8 +-
src/box/sql/expr.c | 40 +-
src/box/sql/fk_constraint.c | 9 +-
src/box/sql/insert.c | 2 +-
src/box/sql/select.c | 25 +-
src/box/sql/sqlInt.h | 13 -
src/box/sql/update.c | 14 +-
src/box/sql/vdbe.c | 222 ++++--
src/box/sql/wherecode.c | 205 +-----
test/sql-tap/autoinc.test.lua | 4 +-
test/sql-tap/default.test.lua | 6 +-
test/sql-tap/e_select1.test.lua | 27 +-
.../gh-3809-implicit-cast-assignment.test.lua | 633 ++++++++++++++++++
.../gh-4230-del-impl-cast-str-to-num.test.lua | 78 +++
test/sql-tap/identifier_case.test.lua | 6 +-
test/sql-tap/in1.test.lua | 4 +-
test/sql-tap/in3.test.lua | 18 +-
test/sql-tap/in4.test.lua | 100 +--
test/sql-tap/index1.test.lua | 24 +-
test/sql-tap/insert3.test.lua | 12 +-
test/sql-tap/intpkey.test.lua | 37 +-
test/sql-tap/join.test.lua | 8 +-
test/sql-tap/limit.test.lua | 2 +-
test/sql-tap/minmax2.test.lua | 6 +-
test/sql-tap/misc1.test.lua | 66 +-
test/sql-tap/numcast.test.lua | 4 +-
test/sql-tap/select1.test.lua | 12 +-
test/sql-tap/select4.test.lua | 12 +-
test/sql-tap/select7.test.lua | 4 +-
test/sql-tap/sort.test.lua | 8 +-
test/sql-tap/subquery.test.lua | 73 +-
test/sql-tap/tkt-3998683a16.test.lua | 36 +-
test/sql-tap/tkt-54844eea3f.test.lua | 8 +-
test/sql-tap/tkt-7bbfb7d442.test.lua | 4 +-
test/sql-tap/tkt-80e031a00f.test.lua | 4 +-
test/sql-tap/tkt-9a8b09f8e6.test.lua | 88 +--
test/sql-tap/tkt-f973c7ac31.test.lua | 32 +-
test/sql-tap/tkt-fc7bd6358f.test.lua | 8 +-
test/sql-tap/tkt1444.test.lua | 4 +-
test/sql-tap/tkt3493.test.lua | 46 +-
test/sql-tap/tkt3841.test.lua | 12 +-
test/sql-tap/transitive1.test.lua | 16 +-
test/sql-tap/triggerA.test.lua | 4 +-
test/sql-tap/unique.test.lua | 8 +-
test/sql-tap/view.test.lua | 2 +-
test/sql-tap/where2.test.lua | 183 +----
test/sql-tap/where5.test.lua | 22 +-
test/sql-tap/whereB.test.lua | 254 +++----
test/sql-tap/whereC.test.lua | 8 +-
test/sql/boolean.result | 14 +-
test/sql/persistency.result | 2 +-
test/sql/types.result | 37 +-
test/sql/types.test.lua | 1 -
54 files changed, 1316 insertions(+), 1166 deletions(-)
create mode 100755 test/sql-tap/gh-3809-implicit-cast-assignment.test.lua
create mode 100755 test/sql-tap/gh-4230-del-impl-cast-str-to-num.test.lua
--
2.25.1
next reply other threads:[~2020-05-28 14:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 14:17 Mergen Imeev [this message]
2020-05-28 14:17 ` [Tarantool-patches] [PATCH 1/6] sql: remove implicit cast for assignment Mergen Imeev
2020-06-01 17:03 ` Vladislav Shpilevoy
2020-06-09 11:41 ` Mergen Imeev
2020-06-09 22:28 ` Vladislav Shpilevoy
2020-05-28 14:17 ` [Tarantool-patches] [PATCH 2/6] sql: remove mem_apply_type() from OP_MakeRecord Mergen Imeev
2020-06-01 17:03 ` Vladislav Shpilevoy
2020-06-09 11:43 ` Mergen Imeev
2020-05-28 14:17 ` [Tarantool-patches] [PATCH 3/6] sql: replace ApplyType by CheckType for IN operator Mergen Imeev
2020-05-28 14:17 ` [Tarantool-patches] [PATCH 4/6] sql: remove mem_apply_type() from OP_MustBeInt Mergen Imeev
2020-06-01 17:04 ` Vladislav Shpilevoy
2020-06-09 11:47 ` Mergen Imeev
2020-06-09 22:28 ` Vladislav Shpilevoy
2020-05-28 14:17 ` [Tarantool-patches] [PATCH 5/6] sql: remove implicit cast from string for comparison Mergen Imeev
2020-06-01 17:04 ` Vladislav Shpilevoy
2020-06-09 11:51 ` Mergen Imeev
2020-06-09 22:29 ` Vladislav Shpilevoy
2020-05-28 14:17 ` [Tarantool-patches] [PATCH 6/6] sql: remove OP_ApplyType Mergen Imeev
2020-06-09 22:29 ` Vladislav Shpilevoy
2020-06-01 17:03 ` [Tarantool-patches] [PATCH 0/6] Remove implicit cast Vladislav Shpilevoy
2020-06-09 11:25 ` Mergen Imeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1590671266.git.imeevma@gmail.com \
--to=imeevma@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tsafin@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 0/6] Remove implicit cast' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox