Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@dev.tarantool.org, korablev@tarantool.org,
	tsafin@tarantool.org, gorcunov@gmail.com
Subject: [Tarantool-patches] [PATCH small 0/2] Aligned lsregion
Date: Fri, 15 May 2020 01:31:02 +0200	[thread overview]
Message-ID: <cover.1589498880.git.v.shpilevoy@tarantool.org> (raw)

The patchset introduces a new function - lsregion_aligned_alloc().
This activity goes in scope of the big issue about lots of
'undefined behaviour' cases among Tarantool sources. One and the
biggest of which is unaligned memory access.

Currently lsregion is used in vinyl for statements and BPS tree
blocks. All of them are not aligned. Addresses are absolutely
arbitrary, sometimes even odd, like ending with 1, 9, etc.

Not counting UB, this is also slower, may be much slower sometimes.

Branch: http://github.com/tarantool/small/tree/gerold103/aligned-lsregion
Issue: https://github.com/tarantool/tarantool/issues/4609

Vladislav Shpilevoy (2):
  lsregion: introduce lsregion_reserve()
  lsregion: provide aligned version of alloc

 small/lsregion.c | 12 ++-----
 small/lsregion.h | 78 +++++++++++++++++++++++++++++++++---------
 test/lsregion.c  | 88 +++++++++++++++++++++++++++++++++++++++++++++++-
 3 files changed, 152 insertions(+), 26 deletions(-)

-- 
2.21.1 (Apple Git-122.3)

             reply	other threads:[~2020-05-14 23:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-14 23:31 Vladislav Shpilevoy [this message]
2020-05-14 23:31 ` [Tarantool-patches] [PATCH small 1/2] lsregion: introduce lsregion_reserve() Vladislav Shpilevoy
2020-05-15 12:35   ` Aleksandr Lyapunov
2020-05-14 23:31 ` [Tarantool-patches] [PATCH small 2/2] lsregion: provide aligned version of alloc Vladislav Shpilevoy
2020-05-15 13:03   ` Aleksandr Lyapunov
2020-05-15 23:24     ` Vladislav Shpilevoy
2020-05-15 12:26 ` [Tarantool-patches] [PATCH small 0/2] Aligned lsregion Aleksandr Lyapunov
2020-05-15 23:22   ` Vladislav Shpilevoy
2020-05-16 19:09     ` Aleksandr Lyapunov
2020-05-17 13:56       ` Vladislav Shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1589498880.git.v.shpilevoy@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=gorcunov@gmail.com \
    --cc=korablev@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=tsafin@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH small 0/2] Aligned lsregion' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox