From: Alexander Turenko <alexander.turenko@tarantool.org> To: Igor Munkin <imun@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH 0/3] box.execute() and box.cfg() idempotence and locking Date: Wed, 13 May 2020 01:18:02 +0300 [thread overview] Message-ID: <cover.1589321083.git.alexander.turenko@tarantool.org> (raw) This patchset provides several fixes for box.execute() and box.cfg() functions when they are called under various circumstances: when a function is saved before box loading and called after it, when a function is called during box loading. Existence of this patchset does not mean that we'll not implement https://github.com/tarantool/tarantool/issues/4726: I don't know whether we will do or will not, but I intend to fix bugs in the existing code. https://github.com/tarantool/tarantool/issues/4231 Totktonada/gh-4231-box-execute-idempotence My review is not more sufficient, because I became co-author of the patchset. Igor, can you, please, review it and pass to a second reviewer (I suggest Vlad)? Alexander Turenko (1): box: always wait box loading in box.execute() Maria (2): box: check whether box is loaded in box.execute() box: always reconfigure box at non-first box.cfg() src/box/lua/load_cfg.lua | 97 +++++++++++++++++-- .../gh-4231-box-cfg-idempotence.test.lua | 34 +++++++ .../gh-4231-box-execute-idempotence.test.lua | 37 +++++++ .../gh-4231-box-execute-locking.test.lua | 69 +++++++++++++ test/box-tap/suite.cfg | 6 ++ test/box-tap/suite.ini | 1 + 6 files changed, 237 insertions(+), 7 deletions(-) create mode 100755 test/box-tap/gh-4231-box-cfg-idempotence.test.lua create mode 100755 test/box-tap/gh-4231-box-execute-idempotence.test.lua create mode 100755 test/box-tap/gh-4231-box-execute-locking.test.lua create mode 100644 test/box-tap/suite.cfg -- 2.25.0
next reply other threads:[~2020-05-12 22:18 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-12 22:18 Alexander Turenko [this message] 2020-05-12 22:18 ` [Tarantool-patches] [PATCH 1/3] box: check whether box is loaded in box.execute() Alexander Turenko 2020-05-22 7:31 ` lvasiliev 2020-06-03 21:58 ` Igor Munkin 2020-06-08 18:58 ` Alexander Turenko 2020-06-11 17:43 ` Igor Munkin 2020-05-12 22:18 ` [Tarantool-patches] [PATCH 2/3] box: always wait box loading " Alexander Turenko 2020-05-22 11:08 ` lvasiliev 2020-06-03 23:12 ` Igor Munkin 2020-05-12 22:18 ` [Tarantool-patches] [PATCH 3/3] box: always reconfigure box at non-first box.cfg() Alexander Turenko 2020-05-22 7:02 ` lvasiliev 2020-06-03 22:41 ` Igor Munkin 2020-06-03 23:22 ` Igor Munkin 2020-06-08 18:59 ` Alexander Turenko 2020-06-17 22:26 ` Vladislav Shpilevoy 2020-06-18 8:41 ` Alexander Turenko 2020-06-18 22:23 ` Vladislav Shpilevoy 2020-05-22 7:06 ` [Tarantool-patches] [PATCH 0/3] box.execute() and box.cfg() idempotence and locking lvasiliev 2020-06-08 18:59 ` Alexander Turenko 2020-06-17 22:30 ` Vladislav Shpilevoy 2020-06-22 10:11 ` Kirill Yukhin 2020-06-23 23:55 ` Alexander Turenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1589321083.git.alexander.turenko@tarantool.org \ --to=alexander.turenko@tarantool.org \ --cc=imun@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 0/3] box.execute() and box.cfg() idempotence and locking' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox