Tarantool development patches archive
 help / color / mirror / Atom feed
From: Nikita Pettik <korablev@tarantool.org>
To: tarantool-patches@dev.tarantool.org
Cc: v.shpilevoy@tarantool.org
Subject: [Tarantool-patches] [PATCH v2 0/2] Stacked diagnostic area follow-ups
Date: Fri, 17 Apr 2020 23:16:44 +0300	[thread overview]
Message-ID: <cover.1587154034.git.korablev@tarantool.org> (raw)

Branch: https://github.com/tarantool/tarantool/tree/np/gh-4887-ref-error-on-prev
Issue: https://github.com/tarantool/tarantool/issues/4887

Changes in v2:

 - modified test so that now it uses weak references to check that
gc collected error objects (i.e. there's no memory leaks);
 - added overflow check in error_ref() so that after 2^32 calls
of box.error.last() or error:prev() error object won't contain
broken reference counter.

Nikita Pettik (2):
  box/error: don't allow overflow of error ref counter
  box/error: ref error.prev while accessing it

 extra/exports           |  1 +
 src/lib/core/diag.c     | 21 +++++++++++++
 src/lib/core/diag.h     | 29 ++++++------------
 src/lua/error.c         |  3 +-
 src/lua/error.lua       | 13 ++++++++
 test/box/error.result   | 68 +++++++++++++++++++++++++++++++++++++++++
 test/box/error.test.lua | 26 ++++++++++++++++
 7 files changed, 140 insertions(+), 21 deletions(-)

-- 
2.17.1

             reply	other threads:[~2020-04-17 20:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-17 20:16 Nikita Pettik [this message]
2020-04-17 20:16 ` [Tarantool-patches] [PATCH v2 1/2] box/error: don't allow overflow of error ref counter Nikita Pettik
2020-04-17 23:54   ` Vladislav Shpilevoy
2020-04-20  1:15     ` Nikita Pettik
2020-04-17 20:16 ` [Tarantool-patches] [PATCH v2 2/2] box/error: ref error.prev while accessing it Nikita Pettik
2020-04-20 14:22 ` [Tarantool-patches] [PATCH v2 0/2] Stacked diagnostic area follow-ups Kirill Yukhin
2020-04-20 14:35   ` Nikita Pettik
2020-04-20 15:29     ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1587154034.git.korablev@tarantool.org \
    --to=korablev@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v2 0/2] Stacked diagnostic area follow-ups' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox