From: imeevma@tarantool.org
To: v.shpilevoy@tarantool.org, tsafin@tarantool.org,
tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v1 0/2] sql: fix comparison in IN operator
Date: Wed, 15 Apr 2020 14:47:37 +0300 [thread overview]
Message-ID: <cover.1586950754.git.imeevma@gmail.com> (raw)
Prior to this patch-set, comparisons in the IN statement were
performed using SCALAR rules in most cases. This patch-set changes
this behavior for the case when the left value is not a vector
whose length is greater than one. Now the left value is searched
among the right values only if they are comparable. If there is a
value that is not comparable with the left value, the operation
throws an error.
https://github.com/tarantool/tarantool/issues/4692
https://github.com/tarantool/tarantool/tree/imeevma/gh-4692-specify-field-types-in-IN-statement
#ChangeLog
- The IN operator now always throws an error if there is a value
on the right that is not comparable with the left value (gh-4256).
Mergen Imeev (2):
sql: fix comparison in IN with list of values
sql: fix comparison in IN with subselect
src/box/sql/expr.c | 43 ++++++++++-
.../gh-4692-comparison-in-IN-operator.test.lua | 54 +++++++++++++
test/sql-tap/in3.test.lua | 2 +-
test/sql-tap/in4.test.lua | 4 +-
test/sql-tap/subquery.test.lua | 8 +-
test/sql-tap/tkt-80e031a00f.test.lua | 8 +-
test/sql/boolean.result | 88 +++++++---------------
7 files changed, 132 insertions(+), 75 deletions(-)
create mode 100755 test/sql-tap/gh-4692-comparison-in-IN-operator.test.lua
--
2.7.4
next reply other threads:[~2020-04-15 11:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 11:47 imeevma [this message]
2020-04-15 11:47 ` [Tarantool-patches] [PATCH v1 1/2] sql: fix comparison in IN with list of values imeevma
2020-04-27 22:53 ` Vladislav Shpilevoy
2020-04-30 10:32 ` Mergen Imeev
2020-05-03 17:17 ` Vladislav Shpilevoy
2020-04-15 11:47 ` [Tarantool-patches] [PATCH v1 2/2] sql: fix comparison in IN with subselect imeevma
2020-04-19 17:47 ` Vladislav Shpilevoy
2020-04-22 10:03 ` Mergen Imeev
2020-04-27 22:53 ` Vladislav Shpilevoy
2020-04-30 10:22 ` Mergen Imeev
2020-05-03 17:17 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1586950754.git.imeevma@gmail.com \
--to=imeevma@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tsafin@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1 0/2] sql: fix comparison in IN operator' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox