From: Sergey Bronnikov <sergeyb@tarantool.org> To: avtikhon@tarantool.org, alexander.turenko@tarantool.org, o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH v3 0/6] Add static analysis with luacheck Date: Tue, 14 Apr 2020 10:55:48 +0300 [thread overview] Message-ID: <cover.1586849129.git.sergeyb@tarantool.org> (raw) Changelog: - removed asserts in test/ to keep following diff-based approach with tests - added separate install target in .travis.mk - added comment regarding ENABLE_DIST in .travis.mk - enabled app-tap in .luacheckrc - removed duplicate warnings W212 and W122 - disabled checking of files in test/var directory GH issue: https://github.com/tarantool/tarantool/issues/4681 GitHub branch: https://github.com/tarantool/tarantool/tree/ligurio/gh-4681-fix-luacheck-warnings Sergey Bronnikov (6): Fix luacheck warnings in src/lua/ Fix luacheck warnings in test/ Fix luacheck warnings in src/box/lua/ Fix luacheck warnings in extra/dist/tarantoolctl.in Add luacheck config gitlab-ci: enable static analysis with luacheck .gitlab-ci.yml | 9 + .luacheckrc | 175 ++++++++++++++++++ .travis.mk | 15 +- extra/dist/tarantoolctl.in | 18 +- src/box/lua/upgrade.lua | 12 +- src/lua/argparse.lua | 6 +- src/lua/buffer.lua | 4 +- src/lua/clock.lua | 2 +- src/lua/crypto.lua | 4 +- src/lua/csv.lua | 5 +- src/lua/digest.lua | 2 +- src/lua/env.lua | 2 +- src/lua/fio.lua | 25 +-- src/lua/httpc.lua | 3 - src/lua/init.lua | 7 +- src/lua/msgpackffi.lua | 16 +- src/lua/socket.lua | 65 ++++--- src/lua/string.lua | 1 - src/lua/swim.lua | 10 +- src/lua/tap.lua | 74 ++++---- src/lua/trigger.lua | 3 - test/app-tap/console.test.lua | 4 - test/app-tap/csv.test.lua | 28 +-- test/app-tap/logger.test.lua | 2 +- test/box-py/box.lua | 2 +- test/box-tap/gc.test.lua | 4 +- test/box/box.lua | 2 +- test/box/hash_multipart.result | 2 +- test/box/hash_multipart.test.lua | 2 +- test/box/lua/cfg_bad_vinyl_dir.lua | 2 +- test/box/lua/cfg_rtree.lua | 2 +- test/box/lua/cfg_test1.lua | 2 +- test/box/lua/cfg_test2.lua | 2 +- test/box/lua/cfg_test3.lua | 2 +- test/box/lua/cfg_test4.lua | 2 +- test/box/lua/cfg_test5.lua | 4 +- test/box/lua/cfg_test6.lua | 2 +- test/box/lua/utils.lua | 3 +- test/box/on_schema_init.lua | 2 +- test/box/proxy.lua | 2 +- test/box/tiny.lua | 2 +- test/box/tree_pk.result | 4 +- test/box/tree_pk.test.lua | 4 +- test/engine/tree_min_max_count.result | 2 +- test/engine/tree_min_max_count.test.lua | 2 +- test/replication-py/master.lua | 2 +- test/replication-py/panic.lua | 2 +- test/replication/master.lua | 2 +- test/replication/replicaset_ro_mostly.result | 2 +- .../replication/replicaset_ro_mostly.test.lua | 2 +- test/sql-tap/analyze3.test.lua | 6 +- test/sql-tap/analyze9.test.lua | 16 +- .../gh-4077-iproto-execute-no-bind.test.lua | 7 +- test/sql-tap/index1.test.lua | 1 - test/sql-tap/join3.test.lua | 2 +- test/sql-tap/select9.test.lua | 10 +- test/sql-tap/tkt-fa7bf5ec.test.lua | 6 +- test/sql-tap/where2.test.lua | 2 +- test/sql/lua/sql_tokenizer.lua | 2 +- test/sql/savepoints.result | 6 +- test/sql/savepoints.test.lua | 6 +- test/sql/triggers.result | 2 +- test/sql/triggers.test.lua | 2 +- test/vinyl/large.lua | 3 +- test/vinyl/txn_proxy.lua | 6 +- test/vinyl/vinyl.lua | 2 +- test/wal_off/rtree_benchmark.result | 2 +- test/wal_off/rtree_benchmark.test.lua | 2 +- test/xlog-py/box.lua | 2 +- test/xlog/panic.lua | 2 +- test/xlog/reader.result | 2 +- test/xlog/reader.test.lua | 2 +- test/xlog/snap_io_rate.test.lua | 2 +- test/xlog/transaction.result | 2 +- test/xlog/transaction.test.lua | 2 +- test/xlog/xlog.lua | 2 +- 76 files changed, 409 insertions(+), 243 deletions(-) create mode 100644 .luacheckrc -- 2.23.0 -- sergeyb@
next reply other threads:[~2020-04-14 7:55 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-14 7:55 Sergey Bronnikov [this message] 2020-04-14 7:56 ` [Tarantool-patches] [PATCH 1/6] Fix luacheck warnings in src/lua/ Sergey Bronnikov 2020-04-14 23:29 ` Vladislav Shpilevoy 2020-04-15 20:51 ` Igor Munkin 2020-04-15 21:40 ` Vladislav Shpilevoy 2020-04-17 9:07 ` Sergey Bronnikov 2020-04-17 9:09 ` Sergey Bronnikov 2020-04-15 20:51 ` Igor Munkin 2020-04-15 21:46 ` Vladislav Shpilevoy 2020-04-16 13:52 ` Igor Munkin 2020-04-17 9:26 ` Sergey Bronnikov 2020-04-17 12:13 ` Igor Munkin 2020-04-14 7:57 ` [Tarantool-patches] [PATCH 2/6] Fix luacheck warnings in test/ Sergey Bronnikov 2020-04-14 23:29 ` Vladislav Shpilevoy 2020-04-17 12:05 ` Igor Munkin 2020-04-17 19:51 ` Sergey Bronnikov 2020-04-17 19:47 ` Sergey Bronnikov 2020-04-16 13:43 ` Igor Munkin 2020-04-14 7:57 ` [Tarantool-patches] [PATCH 3/6] Fix luacheck warnings in src/box/lua/ Sergey Bronnikov 2020-04-14 23:30 ` Vladislav Shpilevoy 2020-04-14 7:58 ` [Tarantool-patches] [PATCH 4/6] Fix luacheck warnings in extra/dist/tarantoolctl.in Sergey Bronnikov 2020-04-14 23:30 ` Vladislav Shpilevoy 2020-04-15 15:35 ` Igor Munkin 2020-04-14 8:01 ` [Tarantool-patches] [PATCH 5/6] Add luacheck config Sergey Bronnikov 2020-04-14 23:30 ` Vladislav Shpilevoy 2020-04-14 8:01 ` [Tarantool-patches] [PATCH 6/6] gitlab-ci: enable static analysis with luacheck Sergey Bronnikov 2020-04-14 23:30 ` [Tarantool-patches] [PATCH v3 7/6] schema: fix index promotion to functional index Vladislav Shpilevoy 2020-04-14 23:30 ` [Tarantool-patches] [PATCH v3 8/6] schema: fix internal symbols dangling in _G Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1586849129.git.sergeyb@tarantool.org \ --to=sergeyb@tarantool.org \ --cc=alexander.turenko@tarantool.org \ --cc=avtikhon@tarantool.org \ --cc=o.piskunov@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v3 0/6] Add static analysis with luacheck' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox