From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> To: tarantool-patches@dev.tarantool.org, alexander.turenko@tarantool.org Subject: [Tarantool-patches] [PATCH 0/4] CMake option to remove feedback daemon Date: Sun, 12 Apr 2020 22:13:26 +0200 [thread overview] Message-ID: <cover.1586722379.git.v.shpilevoy@tarantool.org> (raw) There is a complaint that the feedback daemon is a 'spying' tool and because of that can't be used on Gentoo. Its default disabled option also is not acceptable, the daemon should be eliminated completely. The patchset introduces cmake option ENABLE_FEEDBACK_DAEMON. It is ON by default. When set to OFF, all feedback daemon's code is not included into the binary, its configuration options disappear. The issue is closed in the last commit, but there appeared some side tasks necessary to make it work, these are first 3 commits. Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-3308-cmake-remove-feedback Issue: https://github.com/tarantool/tarantool/issues/3308 Vladislav Shpilevoy (4): box: improve built-in module load panic message feedback: move feedback code to the single file box: yield after initial box_cfg() is finished feedback: add cmake option to disable the daemon src/box/CMakeLists.txt | 10 ++++++++- src/box/box.cc | 15 +++++++++++++- src/box/lua/feedback_daemon.lua | 16 +++++++++++++++ src/box/lua/init.c | 13 ++++++++++-- src/box/lua/load_cfg.lua | 29 +++++++++++++++++++++------ src/box/lua/schema.lua | 17 ---------------- src/trivia/config.h.cmake | 2 ++ test/box-tap/feedback_daemon.test.lua | 23 +++++++++++++++++---- test/box/misc.result | 19 ++++++++++++++++-- test/box/misc.test.lua | 15 +++++++++++++- 10 files changed, 125 insertions(+), 34 deletions(-) -- 2.21.1 (Apple Git-122.3)
next reply other threads:[~2020-04-12 20:13 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-12 20:13 Vladislav Shpilevoy [this message] 2020-04-12 20:13 ` [Tarantool-patches] [PATCH 1/4] box: improve built-in module load panic message Vladislav Shpilevoy 2020-04-12 20:13 ` [Tarantool-patches] [PATCH 2/4] feedback: move feedback code to the single file Vladislav Shpilevoy 2020-04-12 20:13 ` [Tarantool-patches] [PATCH 3/4] box: yield after initial box_cfg() is finished Vladislav Shpilevoy 2020-04-12 20:13 ` [Tarantool-patches] [PATCH 4/4] feedback: add cmake option to disable the daemon Vladislav Shpilevoy 2020-04-15 17:28 ` Serge Petrenko 2020-04-15 20:04 ` Vladislav Shpilevoy 2020-04-12 20:19 ` [Tarantool-patches] [PATCH 0/4] CMake option to remove feedback daemon Vladislav Shpilevoy 2020-04-17 7:04 ` Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1586722379.git.v.shpilevoy@tarantool.org \ --to=v.shpilevoy@tarantool.org \ --cc=alexander.turenko@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 0/4] CMake option to remove feedback daemon' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox