From: imeevma@tarantool.org
To: korablev@tarantool.org, v.shpilevoy@tarantool.org,
tsafin@tarantool.org, tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v2 0/2] sql: fix order of inserted rows
Date: Sun, 12 Apr 2020 19:29:54 +0300 [thread overview]
Message-ID: <cover.1586708735.git.imeevma@gmail.com> (raw)
This patch-set fixes order of inserted rows in case ephemeral
space is used. The order now is the same in which these values
were inserted originally. Wrong order could lead to an error in
case AUTOINCREMENT feature was used.
https://github.com/tarantool/tarantool/issues/4256
https://github.com/tarantool/tarantool/tree/imeevma/gh-4256-fix-order-during-insertion
#ChangeLog
- The inserted values will now always be inserted in the order in
which they were given (gh-4256).
Mergen Imeev (2):
sql: specify field types in ephemeral space format
sql: do not change order of inserted values
src/box/space_def.c | 5 +-
src/box/space_def.h | 3 +-
src/box/sql.c | 68 ++++++++++++++++------
src/box/sql/insert.c | 19 +++++-
src/box/sql/select.c | 2 +
src/box/sql/sqlInt.h | 2 +
src/box/sql/vdbe.c | 19 +-----
src/box/tuple_format.c | 22 ++++---
...256-do-not-change-order-during-insertion.result | 50 ++++++++++++++++
...6-do-not-change-order-during-insertion.test.lua | 15 +++++
10 files changed, 153 insertions(+), 52 deletions(-)
create mode 100644 test/sql/gh-4256-do-not-change-order-during-insertion.result
create mode 100644 test/sql/gh-4256-do-not-change-order-during-insertion.test.lua
--
2.7.4
next reply other threads:[~2020-04-12 16:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-12 16:29 imeevma [this message]
2020-04-12 16:29 ` [Tarantool-patches] [PATCH v2 1/2] sql: specify field types in ephemeral space format imeevma
2020-04-13 22:47 ` Nikita Pettik
2020-04-12 16:29 ` [Tarantool-patches] [PATCH v2 2/2] sql: do not change order of inserted values imeevma
2020-04-13 22:59 ` Nikita Pettik
2020-04-13 22:35 ` [Tarantool-patches] [PATCH v2 0/2] sql: fix order of inserted rows Nikita Pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1586708735.git.imeevma@gmail.com \
--to=imeevma@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tsafin@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 0/2] sql: fix order of inserted rows' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox