From: Nikita Pettik <korablev@tarantool.org> To: tarantool-patches@dev.tarantool.org Cc: v.shpilevoy@tarantool.org Subject: [Tarantool-patches] [PATCH 0/2] vinyl: fix uninitialized memory accesses Date: Thu, 9 Apr 2020 00:37:06 +0300 [thread overview] Message-ID: <cover.1586381297.git.korablev@tarantool.org> (raw) It is found that if vy_stmt_alloc() fails (due to OOM or most likely owing to exceeding max tuple size) during compaction process, it may result in instance crashes. This patch-set contains two fixes for problems connected with wrong handling of vy_stmt_alloc() failure. Branch: https://github.com/tarantool/tarantool/commits/np/gh-4864-access-to-uninit-mem Issue: https://github.com/tarantool/tarantool/issues/4864 @ChangeLog: * Fixed crash during compaction due to tuples with size exceeding vinyl_max_tuple_size setting. Nikita Pettik (2): vinyl: init all vars before cleanup in vy_lsm_split_range() vinyl: clean-up read views if *_build_history() fails src/box/vy_lsm.c | 4 +- src/box/vy_stmt.c | 5 + src/box/vy_write_iterator.c | 5 +- src/errinj.h | 1 + test/box/errinj.result | 1 + .../gh-4864-stmt-alloc-fail-compact.result | 144 ++++++++++++++++++ .../gh-4864-stmt-alloc-fail-compact.test.lua | 73 +++++++++ test/vinyl/suite.ini | 2 +- 8 files changed, 231 insertions(+), 4 deletions(-) create mode 100644 test/vinyl/gh-4864-stmt-alloc-fail-compact.result create mode 100644 test/vinyl/gh-4864-stmt-alloc-fail-compact.test.lua -- 2.17.1
next reply other threads:[~2020-04-08 21:37 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-08 21:37 Nikita Pettik [this message] 2020-04-08 21:37 ` [Tarantool-patches] [PATCH 1/2] vinyl: init all vars before cleanup in vy_lsm_split_range() Nikita Pettik 2020-04-09 8:18 ` Konstantin Osipov 2020-04-09 10:55 ` Nikita Pettik 2020-04-09 11:07 ` Konstantin Osipov 2020-04-09 11:26 ` Nikita Pettik 2020-04-10 15:13 ` Vladislav Shpilevoy 2020-04-10 15:40 ` Nikita Pettik 2020-04-10 18:24 ` Nikita Pettik 2020-04-11 17:39 ` Vladislav Shpilevoy 2020-04-13 22:29 ` Nikita Pettik 2020-04-14 21:40 ` Nikita Pettik 2020-04-08 21:37 ` [Tarantool-patches] [PATCH 2/2] vinyl: clean-up read views if *_build_history() fails Nikita Pettik 2020-04-09 8:19 ` Konstantin Osipov 2020-04-09 11:09 ` Nikita Pettik 2020-04-10 15:13 ` Vladislav Shpilevoy 2020-04-10 15:47 ` Nikita Pettik 2020-04-10 21:45 ` Nikita Pettik 2020-04-10 22:32 ` Vladislav Shpilevoy 2020-04-11 17:30 ` Konstantin Osipov 2020-04-13 22:31 ` Nikita Pettik 2020-04-13 22:35 ` Konstantin Osipov 2020-04-13 22:11 ` Nikita Pettik 2020-04-11 17:39 ` Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1586381297.git.korablev@tarantool.org \ --to=korablev@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 0/2] vinyl: fix uninitialized memory accesses' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox