Tarantool development patches archive
 help / color / mirror / Atom feed
From: Chris Sosnin <k.sosnin@tarantool.org>
To: tarantool-patches@dev.tarantool.org, korablev@tarantool.org
Subject: [Tarantool-patches] [PATCH 0/2] fix box.session.push formatting
Date: Mon,  6 Apr 2020 17:33:28 +0300	[thread overview]
Message-ID: <cover.1586183184.git.k.sosnin@tarantool.org> (raw)

Nikita, please, do a second review.

First commit moves current output format to struct session.
Second commit adds Lua output format support for push().

@ChangeLog
- Add Lua output format support for box.session.push

issue: https://github.com/tarantool/tarantool/issues/4686
branch: https://github.com/tarantool/tarantool/tree/ksosnin/gh-4686-session-push-fmt

Chris Sosnin (2):
  session: store output format in struct session
  box: fix formatting in session.push

 extra/exports                 |  2 +
 src/box/lua/console.c         | 56 +++++++++++++++++++-------
 src/box/lua/console.lua       | 76 +++++++++++++++++++++++++++--------
 src/box/session.h             | 22 +++++++---
 test/app-tap/console.test.lua | 38 +++++++++++++++++-
 5 files changed, 155 insertions(+), 39 deletions(-)

-- 
2.21.1 (Apple Git-122.3)

             reply	other threads:[~2020-04-06 14:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-06 14:33 Chris Sosnin [this message]
2020-04-06 14:33 ` [Tarantool-patches] [PATCH 1/2] session: store output format in struct session Chris Sosnin
2020-04-07 21:09   ` Nikita Pettik
2020-04-06 14:33 ` [Tarantool-patches] [PATCH 2/2] box: fix formatting in session.push Chris Sosnin
2020-04-07 21:26   ` Nikita Pettik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1586183184.git.k.sosnin@tarantool.org \
    --to=k.sosnin@tarantool.org \
    --cc=korablev@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 0/2] fix box.session.push formatting' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox