From: imeevma@tarantool.org
To: korablev@tarantool.org, tsafin@tarantool.org,
tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v4 0/3] sql: fix CAST() from BLOB to INTEGER
Date: Fri, 27 Mar 2020 14:33:38 +0300 [thread overview]
Message-ID: <cover.1585308644.git.imeevma@gmail.com> (raw)
This patch-set fixes CAST() from BLOB to INTEGER in case a BLOB
does not have '\0'.
https://github.com/tarantool/tarantool/issues/4766
https://github.com/tarantool/tarantool/tree/imeevma/gh-4766-fix-blob-size-for-cast
@Changelog
- Explicit and implicit cast from string contains DOUBLE value to
INTEGER or UNSIGNED was disallowed.
- Maximum length of a BLOB that is allowed to be cast to INTEGER
or UNSIGNED was limited to 12287 bytes.
- Fixed wrong behaviour of CAST() from BLOB to INTEGER in case a
BLOB does not have '\0'. (gh-4766)
Mergen Imeev (3):
sql: fix CAST() from STRING to INTEGER
sql: fix implicit cast from STRING to INTEGER
sql: add '\0' to the BLOB when it is cast to INTEGER
src/box/sql/util.c | 17 ++-
src/box/sql/vdbe.c | 11 +-
src/box/sql/vdbeInt.h | 1 -
src/box/sql/vdbemem.c | 45 ++-----
test/sql-tap/e_select1.test.lua | 2 +-
.../gh-4766-wrong-cast-from-blob-to-int.test.lua | 150 +++++++++++++++++++++
test/sql-tap/intpkey.test.lua | 2 +-
test/sql-tap/join.test.lua | 4 +-
test/sql-tap/subquery.test.lua | 6 +-
test/sql-tap/tkt-9a8b09f8e6.test.lua | 4 +-
test/sql/types.result | 23 ++--
11 files changed, 203 insertions(+), 62 deletions(-)
create mode 100755 test/sql-tap/gh-4766-wrong-cast-from-blob-to-int.test.lua
--
2.7.4
next reply other threads:[~2020-03-27 11:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 11:33 imeevma [this message]
2020-03-27 11:33 ` [Tarantool-patches] [PATCH v4 1/3] sql: fix CAST() from STRING " imeevma
2020-03-27 16:46 ` Nikita Pettik
2020-04-10 10:39 ` Mergen Imeev
2020-04-10 10:43 ` Mergen Imeev
2020-04-10 13:05 ` Nikita Pettik
2020-04-10 17:06 ` Imeev Mergen
2020-04-15 11:13 ` Nikita Pettik
2020-04-10 12:46 ` Nikita Pettik
2020-04-10 13:05 ` Imeev Mergen
2020-03-27 11:33 ` [Tarantool-patches] [PATCH v4 2/3] sql: fix implicit cast " imeevma
2020-03-27 16:54 ` Nikita Pettik
2020-04-10 10:41 ` Mergen Imeev
2020-04-10 12:57 ` Nikita Pettik
2020-04-10 18:09 ` Mergen Imeev
2020-03-27 11:33 ` [Tarantool-patches] [PATCH v4 3/3] sql: add '\0' to the BLOB when it is cast " imeevma
2020-03-27 16:54 ` Nikita Pettik
2020-04-16 0:03 ` [Tarantool-patches] [PATCH v4 0/3] sql: fix CAST() from BLOB " Nikita Pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1585308644.git.imeevma@gmail.com \
--to=imeevma@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tsafin@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v4 0/3] sql: fix CAST() from BLOB to INTEGER' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox