From: Igor Munkin <imun@tarantool.org>
To: Sergey Ostanevich <sergos@tarantool.org>,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH luajit 0/2] Trace abort on FFI sandwich or mode change
Date: Fri, 27 Mar 2020 13:47:49 +0300 [thread overview]
Message-ID: <cover.1585304087.git.imun@tarantool.org> (raw)
This series closes two issues related to the JIT machinery behaviour:
* "FFI sandwich"(*) detection is introduced. If sandwich is detected
while trace recording the recording is aborted. The sandwich detected
while mcode execution leads to the platform panic.
* luaJIT_setmode call is prohibited while mcode execution and leads to
the platform panic.
(*) The following stack mix is called FFI sandwich.
| Lua-FFI -> С routine -> Lua-C API -> Lua VM
This sort of re-entrancy is explicitly not supported by LuaJIT
compiler. For more info see [1].
Branch: https://github.com/tarantool/luajit/tree/imun/ffi-sandwich
[1]: https://github.com/tarantool/tarantool/issues/4427
Igor Munkin (2):
jit: abort trace recording and execution for C API
jit: abort trace execution on JIT mode change
src/lj_api.c | 35 ++++++++++----
src/lj_dispatch.c | 5 ++
src/lj_errmsg.h | 2 +
test/gh-4427-ffi-sandwich/CMakeLists.txt | 1 +
test/gh-4427-ffi-sandwich/libsandwich.c | 59 ++++++++++++++++++++++++
test/gh-4427-ffi-sandwich/test.lua | 26 +++++++++++
test/lj-flush-on-trace/CMakeLists.txt | 1 +
test/lj-flush-on-trace/libflush.c | 31 +++++++++++++
test/lj-flush-on-trace/test.lua | 25 ++++++++++
9 files changed, 176 insertions(+), 9 deletions(-)
create mode 100644 test/gh-4427-ffi-sandwich/CMakeLists.txt
create mode 100644 test/gh-4427-ffi-sandwich/libsandwich.c
create mode 100644 test/gh-4427-ffi-sandwich/test.lua
create mode 100644 test/lj-flush-on-trace/CMakeLists.txt
create mode 100644 test/lj-flush-on-trace/libflush.c
create mode 100644 test/lj-flush-on-trace/test.lua
--
2.25.0
next reply other threads:[~2020-03-27 10:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 10:47 Igor Munkin [this message]
2020-03-27 10:47 ` [Tarantool-patches] [PATCH luajit 1/2] jit: abort trace recording and execution for C API Igor Munkin
2020-03-28 16:33 ` Sergey Ostanevich
2020-03-28 20:30 ` Igor Munkin
2020-03-29 9:21 ` Sergey Ostanevich
2020-03-29 10:45 ` Igor Munkin
2020-03-30 8:58 ` Sergey Ostanevich
2020-03-30 14:25 ` Igor Munkin
2020-04-03 21:06 ` Sergey Ostanevich
2020-04-03 21:31 ` Igor Munkin
2020-04-02 23:41 ` Vladislav Shpilevoy
2020-04-04 11:55 ` Igor Munkin
2020-04-04 21:37 ` Vladislav Shpilevoy
2020-04-07 21:16 ` Igor Munkin
2020-03-27 10:47 ` [Tarantool-patches] [PATCH luajit 2/2] jit: abort trace execution on JIT mode change Igor Munkin
2020-03-28 19:36 ` Sergey Ostanevich
2020-03-29 10:46 ` Igor Munkin
2020-04-02 23:41 ` [Tarantool-patches] [PATCH luajit 0/2] Trace abort on FFI sandwich or " Vladislav Shpilevoy
2020-04-03 21:32 ` Igor Munkin
2020-04-04 21:36 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1585304087.git.imun@tarantool.org \
--to=imun@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=sergos@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 0/2] Trace abort on FFI sandwich or mode change' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox