Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@dev.tarantool.org, imun@tarantool.org,
	korablev@tarantool.org
Subject: [Tarantool-patches] [PATCH v2 0/3] fio: close unused descriptors automatically
Date: Tue,  3 Mar 2020 00:29:50 +0100	[thread overview]
Message-ID: <cover.1583191602.git.v.shpilevoy@tarantool.org> (raw)

The patchset introduces a fiber worker singleton object and uses
it for garbage collection of fio and SWIM objects. This is a
workaround for inability to yield in ffi.gc hook, which is used by
fio and SWIM.

SWIM had GC before, but it was creating a new fiber for each GC.
Fio didn't have GC.

Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4727-fio-gc
Issue: https://github.com/tarantool/tarantool/issues/4727

@ChangeLog
- fio descriptors are closed on garbage collection (gh-4727).

Changes in V2:
- Added a special single fiber for garbage collection of objects,
  which yield in their destructors.

Vladislav Shpilevoy (3):
  fiber: introduce schedule_task() internal function
  fio: close unused descriptors automatically
  swim: use fiber._internal.schedule_task() for GC

 src/lua/fiber.c                  |  15 +++++
 src/lua/fiber.lua                |  60 ++++++++++++++++++
 src/lua/fio.lua                  |  34 ++++++++--
 src/lua/swim.lua                 |  11 ++--
 test/app/fiber.result            |  72 +++++++++++++++++++++
 test/app/fiber.test.lua          |  41 ++++++++++++
 test/app/gh-4727-fio-gc.result   | 104 +++++++++++++++++++++++++++++++
 test/app/gh-4727-fio-gc.test.lua |  60 ++++++++++++++++++
 8 files changed, 385 insertions(+), 12 deletions(-)
 create mode 100644 test/app/gh-4727-fio-gc.result
 create mode 100644 test/app/gh-4727-fio-gc.test.lua

-- 
2.21.1 (Apple Git-122.3)

             reply	other threads:[~2020-03-02 23:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-02 23:29 Vladislav Shpilevoy [this message]
2020-03-02 23:29 ` [Tarantool-patches] [PATCH v2 1/3] fiber: introduce schedule_task() internal function Vladislav Shpilevoy
2020-03-19 14:52   ` Igor Munkin
2020-03-20  0:00     ` Vladislav Shpilevoy
2020-03-20 10:48       ` Igor Munkin
2020-03-02 23:29 ` [Tarantool-patches] [PATCH v2 2/3] fio: close unused descriptors automatically Vladislav Shpilevoy
2020-03-19 14:53   ` Igor Munkin
2020-03-19 22:53     ` Igor Munkin
2020-03-20  0:00       ` Vladislav Shpilevoy
2020-03-20 10:48         ` Igor Munkin
2020-03-20 21:28           ` Vladislav Shpilevoy
2020-03-20 21:28             ` Igor Munkin
2020-03-02 23:29 ` [Tarantool-patches] [PATCH v2 3/3] swim: use fiber._internal.schedule_task() for GC Vladislav Shpilevoy
2020-03-19 14:53   ` Igor Munkin
2020-03-26  1:08 ` [Tarantool-patches] [PATCH v2 0/3] fio: close unused descriptors automatically Nikita Pettik
2020-03-26 12:56 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1583191602.git.v.shpilevoy@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=imun@tarantool.org \
    --cc=korablev@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v2 0/3] fio: close unused descriptors automatically' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox