From: Serge Petrenko <sergepetrenko@tarantool.org>
To: v.shpilevoy@tarantool.org
Cc: kirichenkoga@gmail.com, tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v5 0/4] replication: fix applying of rows originating from local instance
Date: Fri, 28 Feb 2020 11:34:41 +0300 [thread overview]
Message-ID: <cover.1582877598.git.sergepetrenko@tarantool.org> (raw)
https://github.com/tarantool/tarantool/issues/4739
https://github.com/tarantool/tarantool/tree/sp/gh-4739-vclock-assert-v4
@ChangeLog
- fix possible vclock ordering violations in
master-master replication when one of the
masters restarts (gh-4739)
Changes in v5:
- review fixes as per reviews from Vlad and Kostja
- added a test
- applied Vlads test amendments
- added a changelog
Changes in v4:
- move row skipping logic from recovery to relay
- encode a list of instances whose rows to skip
in SUBSCRIBE request insead of encoding
is_orhpan status
Changes in v3:
- review fixes as per review from Vlad
- instead of skipping rows on replica side,
do it on master side, by patching recovery
to silently follow rows coming from a certain
instance.
Changes in v2:
- review fixes as per review from Kostja
Serge Petrenko (4):
box: expose box_is_orphan method
wal: warn when trying to write a record with a broken lsn
replication: implement an instance id filter for relay
replication: do not relay rows coming from a remote instance back to
it
src/box/applier.cc | 7 +-
src/box/box.cc | 13 ++-
src/box/box.h | 3 +
src/box/iproto_constants.h | 1 +
src/box/relay.cc | 15 +++-
src/box/relay.h | 3 +-
src/box/wal.c | 20 ++++-
src/box/xrow.c | 40 ++++++++-
src/box/xrow.h | 36 +++++---
src/lib/core/cbus.h | 7 ++
src/lib/core/errinj.h | 3 +-
test/box/errinj.result | 1 +
test/replication/gh-4739-vclock-assert.result | 88 +++++++++++++++++++
.../gh-4739-vclock-assert.test.lua | 36 ++++++++
test/replication/suite.cfg | 1 +
test/replication/suite.ini | 2 +-
16 files changed, 250 insertions(+), 26 deletions(-)
create mode 100644 test/replication/gh-4739-vclock-assert.result
create mode 100644 test/replication/gh-4739-vclock-assert.test.lua
--
2.21.1 (Apple Git-122.3)
next reply other threads:[~2020-02-28 8:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 8:34 Serge Petrenko [this message]
2020-02-28 8:34 ` [Tarantool-patches] [PATCH v5 1/4] box: expose box_is_orphan method Serge Petrenko
2020-02-28 8:34 ` [Tarantool-patches] [PATCH v5 2/4] wal: warn when trying to write a record with a broken lsn Serge Petrenko
2020-02-28 23:24 ` Vladislav Shpilevoy
2020-02-29 9:22 ` Serge Petrenko
2020-02-28 8:34 ` [Tarantool-patches] [PATCH v5 3/4] replication: implement an instance id filter for relay Serge Petrenko
2020-02-28 8:34 ` [Tarantool-patches] [PATCH v5 4/4] replication: do not relay rows coming from a remote instance back to it Serge Petrenko
2020-02-28 23:24 ` [Tarantool-patches] [PATCH v5 0/4] replication: fix applying of rows originating from local instance Vladislav Shpilevoy
2020-03-02 4:32 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1582877598.git.sergepetrenko@tarantool.org \
--to=sergepetrenko@tarantool.org \
--cc=kirichenkoga@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v5 0/4] replication: fix applying of rows originating from local instance' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox