From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@dev.tarantool.org,
alexander.turenko@tarantool.org, korablev@tarantool.org
Subject: [Tarantool-patches] [PATCH 0/3] Fix upgrade from 2.1 sequence
Date: Mon, 17 Feb 2020 21:57:19 +0100 [thread overview]
Message-ID: <cover.1581972845.git.v.shpilevoy@tarantool.org> (raw)
The patchset fixes inability to upgrade from 2.1 if there is an
automatically generated sequence. The problem was that upgrade
tried to update a tuple in _space_sequence in-place, calling
space:update() method. But it was not properly supported for
_space_sequence. The patchset turns it into delete + insert, and
bans updates for this space.
Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4771-2.2-upgrade
Issue: https://github.com/tarantool/tarantool/issues/4771
@ChangeLog
- Fixed inability to upgrade from 2.1, if there was an
automatically generated sequence (gh-4771).
Vladislav Shpilevoy (3):
upgrade: add missing sys triggers off and erasure
box: forbid to update/replace _space_sequence
upgrade: fix generated sequence upgrade from 2.1
src/box/alter.cc | 8 +-
src/box/lua/upgrade.lua | 47 ++--
test/box/sequence.result | 19 ++
test/box/sequence.test.lua | 9 +
test/xlog/gh-4771-upgrade.result | 78 ++++++
test/xlog/gh-4771-upgrade.test.lua | 24 ++
test/xlog/suite.cfg | 5 -
test/xlog/suite.ini | 3 +-
test/xlog/upgrade.result | 265 ------------------
test/xlog/upgrade.test.lua | 46 ---
.../00000000000000000014.snap | Bin 0 -> 4622 bytes
.../2.1.3/gh-4771-upgrade-sequence/fill.lua | 14 +
12 files changed, 172 insertions(+), 346 deletions(-)
create mode 100644 test/xlog/gh-4771-upgrade.result
create mode 100644 test/xlog/gh-4771-upgrade.test.lua
delete mode 100644 test/xlog/suite.cfg
delete mode 100644 test/xlog/upgrade.result
delete mode 100644 test/xlog/upgrade.test.lua
create mode 100644 test/xlog/upgrade/2.1.3/gh-4771-upgrade-sequence/00000000000000000014.snap
create mode 100644 test/xlog/upgrade/2.1.3/gh-4771-upgrade-sequence/fill.lua
--
2.21.1 (Apple Git-122.3)
next reply other threads:[~2020-02-17 20:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 20:57 Vladislav Shpilevoy [this message]
2020-02-17 20:57 ` [Tarantool-patches] [PATCH 1/3] upgrade: add missing sys triggers off and erasure Vladislav Shpilevoy
2020-02-21 15:20 ` Nikita Pettik
2020-02-22 16:17 ` Vladislav Shpilevoy
2020-02-17 20:57 ` [Tarantool-patches] [PATCH 2/3] box: forbid to update/replace _space_sequence Vladislav Shpilevoy
2020-02-21 15:29 ` Nikita Pettik
2020-02-22 16:16 ` Vladislav Shpilevoy
2020-02-17 20:57 ` [Tarantool-patches] [PATCH 3/3] upgrade: fix generated sequence upgrade from 2.1 Vladislav Shpilevoy
2020-02-21 15:42 ` Nikita Pettik
2020-02-22 16:16 ` Vladislav Shpilevoy
2020-02-24 19:48 ` [Tarantool-patches] [PATCH 0/3] Fix upgrade from 2.1 sequence Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1581972845.git.v.shpilevoy@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 0/3] Fix upgrade from 2.1 sequence' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox