From: Serge Petrenko <sergepetrenko@tarantool.org> To: alexander.turenko@tarantool.org Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH v2 0/2] build: link curl with c-ares Date: Tue, 21 Jan 2020 14:54:30 +0300 [thread overview] Message-ID: <cover.1579605136.git.sergepetrenko@tarantool.org> (raw) The first commit adds c-ares as a submodule and starts using it when building libcurl. This allows to eliminate some problems the curl's default threaded resolver has when DNS server doesn't respond for a long time. The second commit adds curl and c-ares version output to `tarantool --version` and also to `require "tarantool"` table in Lua. This may be useful for debugging purposes. Since the first commit is intended as a bugfix, it should be pushed to all branches, starting from 1.10. However, the second one looks more like a feature so I suggest it be pushed only to master. Changes in v2: - use CMake when building ares instead of configure - minor fixes as per review from @Totktonada https://github.com/tarantool/tarantool/tree/sp/gh-4591-link-curl-with-c-ares-full-ci https://github.com/tarantool/tarantool/issues/4591 Serge Petrenko (2): build: link bundled libcurl with c-ares build: add bundled curl and c-ares to version output .gitmodules | 3 ++ CMakeLists.txt | 6 ++++ cmake/BuildAres.cmake | 71 +++++++++++++++++++++++++++++++++++++++ cmake/BuildLibCURL.cmake | 41 ++++++++++++++++++++-- src/CMakeLists.txt | 3 +- src/lua/init.c | 14 ++++++++ src/main.cc | 6 ++++ src/trivia/config.h.cmake | 4 +++ test/box-py/args.result | 8 +++++ test/box-py/args.test.py | 5 ++- third_party/c-ares | 1 + 11 files changed, 158 insertions(+), 4 deletions(-) create mode 100644 cmake/BuildAres.cmake create mode 160000 third_party/c-ares -- 2.21.0 (Apple Git-122)
next reply other threads:[~2020-01-21 11:54 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-21 11:54 Serge Petrenko [this message] 2020-01-21 11:54 ` [Tarantool-patches] [PATCH v2 1/2] build: link bundled libcurl " Serge Petrenko 2020-02-08 19:42 ` Alexander Turenko 2020-03-03 16:46 ` Serge Petrenko 2020-03-03 16:51 ` Serge Petrenko 2020-03-03 23:20 ` Alexander Turenko 2020-03-04 12:42 ` Alexander Turenko 2020-03-05 5:27 ` Kirill Yukhin 2020-01-21 11:54 ` [Tarantool-patches] [PATCH v2 2/2] build: add bundled curl and c-ares to version output Serge Petrenko 2020-03-04 12:03 ` Alexander Turenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1579605136.git.sergepetrenko@tarantool.org \ --to=sergepetrenko@tarantool.org \ --cc=alexander.turenko@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v2 0/2] build: link curl with c-ares' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox