From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> To: tarantool-patches@dev.tarantool.org, kostja.osipov@gmail.com Subject: [Tarantool-patches] [PATCH v2 0/3] Fiber storage leak Date: Thu, 16 Jan 2020 22:54:20 +0100 [thread overview] Message-ID: <cover.1579211601.git.v.shpilevoy@tarantool.org> (raw) The patchset makes fiber.storage be always deleted. Regardless of where was it created - in a fiber born in the Lua land, or in a fiber serving IProto requests and accessing Lua. That removes - a leak occurred each time when fiber storage was created for an IProto request; - a possibility to see previous request's artifacts left in fiber.storage; And makes possible to use fiber.storage as request-local data. Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4662-fiber-storage-leak Issue: https://github.com/tarantool/tarantool/issues/4662 Changes in v2: - Renamed back fiber.on_cleanup -> fiber.on_stop; - Removed dead code from box_process_call/eval(), which is now handled by iproto. Vladislav Shpilevoy (3): fiber: unref fiber.storage via global Lua state fiber: destroy fiber.storage created by iproto box: remove dead code from box_process_call/eval() src/box/call.c | 28 +------ src/box/iproto.cc | 44 ++++++++-- src/box/txn.c | 1 + src/lib/core/fiber.c | 18 +++- src/lib/core/fiber.h | 14 +++- src/lua/fiber.c | 35 ++++++-- test/app/gh-4662-fiber-storage-leak.result | 88 ++++++++++++++++++++ test/app/gh-4662-fiber-storage-leak.test.lua | 43 ++++++++++ 8 files changed, 230 insertions(+), 41 deletions(-) create mode 100644 test/app/gh-4662-fiber-storage-leak.result create mode 100644 test/app/gh-4662-fiber-storage-leak.test.lua -- 2.21.1 (Apple Git-122.3)
next reply other threads:[~2020-01-16 21:54 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-16 21:54 Vladislav Shpilevoy [this message] 2020-01-16 21:54 ` [Tarantool-patches] [PATCH v2 1/3] fiber: unref fiber.storage via global Lua state Vladislav Shpilevoy 2020-01-17 7:30 ` Konstantin Osipov 2020-01-16 21:54 ` [Tarantool-patches] [PATCH v2 2/3] fiber: destroy fiber.storage created by iproto Vladislav Shpilevoy 2020-01-16 22:00 ` Cyrill Gorcunov 2020-01-17 7:47 ` Konstantin Osipov 2020-01-17 8:06 ` Cyrill Gorcunov 2020-01-17 7:45 ` Konstantin Osipov 2020-01-19 17:32 ` Vladislav Shpilevoy 2020-01-20 7:22 ` Konstantin Osipov 2020-01-20 19:15 ` Georgy Kirichenko 2020-01-21 22:21 ` Vladislav Shpilevoy 2020-01-21 22:32 ` Konstantin Osipov 2020-01-16 21:54 ` [Tarantool-patches] [PATCH v2 3/3] box: remove dead code from box_process_call/eval() Vladislav Shpilevoy 2020-01-17 7:46 ` Konstantin Osipov 2020-01-17 7:47 ` Konstantin Osipov 2020-01-17 17:41 ` Georgy Kirichenko 2020-01-19 17:32 ` Vladislav Shpilevoy 2020-01-20 19:21 ` Georgy Kirichenko 2020-01-18 19:27 ` [Tarantool-patches] [PATCH v2 0/3] Fiber storage leak Igor Munkin 2020-02-15 1:02 ` Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1579211601.git.v.shpilevoy@tarantool.org \ --to=v.shpilevoy@tarantool.org \ --cc=kostja.osipov@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v2 0/3] Fiber storage leak' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox