From: Ilya Kosarev <i.kosarev@tarantool.org>
To: tarantool-patches@dev.tarantool.org
Cc: v.shpilevoy@tarantool.org
Subject: [Tarantool-patches] [PATCH v2 0/2] Safe truncation and deletion
Date: Tue, 14 Jan 2020 00:31:21 +0300 [thread overview]
Message-ID: <cover.1578951026.git.i.kosarev@tarantool.org> (raw)
space:truncate() and space:delete() could fail on memory allocations
when reaching memtx_memory limit. As far as it is quite an ill
behaviour, it is fixed in this patchset through memtx quota enlargement.
Also possible bps_tree_create_leaf NULL dereference issue is fixed.
Branch: https://github.com/tarantool/tarantool/tree/i.kosarev/gh-3807-safe-alloc-on-truncation
Issue: https://github.com/tarantool/tarantool/issues/3807
Changes in v2:
Approach changed completely: now we are not trying to allocate
service tuples in some safe way, but increasing memtx quota so
that space:truncate() and space:delete() won't fail on allocation.
Ilya Kosarev (2):
b-tree: return NULL on matras_alloc fail
memtx: increase the memory quota if needed to truncate or delete
src/box/blackhole.c | 1 +
src/box/box.cc | 36 +++++++++++++++++++++++++++++++++++-
src/box/engine.c | 11 +++++++++++
src/box/engine.h | 9 +++++++++
src/box/memtx_engine.c | 20 ++++++++++++++++++++
src/box/memtx_engine.h | 4 ++++
src/box/service_engine.c | 1 +
src/box/sysview.c | 1 +
src/box/vinyl.c | 1 +
src/lib/salad/bps_tree.h | 7 +++++--
10 files changed, 88 insertions(+), 3 deletions(-)
--
2.17.1
next reply other threads:[~2020-01-13 21:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 21:31 Ilya Kosarev [this message]
2020-01-13 21:31 ` [Tarantool-patches] [PATCH v2 1/2] b-tree: return NULL on matras_alloc fail Ilya Kosarev
2020-01-14 21:00 ` Vladislav Shpilevoy
2020-01-20 18:13 ` Ilya Kosarev
2020-01-13 21:31 ` [Tarantool-patches] [PATCH v2 2/2] memtx: increase the memory quota if needed to truncate or delete Ilya Kosarev
2020-01-14 21:00 ` Vladislav Shpilevoy
2020-01-20 18:13 ` Ilya Kosarev
2020-01-24 11:21 ` Konstantin Osipov
-- strict thread matches above, loose matches on Subject: below --
2020-01-10 0:36 [Tarantool-patches] [PATCH v2 0/2] Safe truncation and deletion Ilya Kosarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1578951026.git.i.kosarev@tarantool.org \
--to=i.kosarev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 0/2] Safe truncation and deletion' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox